openshift / cluster-monitoring-operator

Manage the OpenShift monitoring stack
Apache License 2.0
247 stars 363 forks source link

OBSDOCS-883: change docs to correct retention time uwm prometheus #2277

Closed marioferh closed 4 months ago

marioferh commented 7 months ago

Documentation for User Workload Monitoring implies that default retention time is 15d, when it is actually 24h in practice

openshift-ci-robot commented 7 months ago

@marioferh: This pull request references OBSDOCS-883 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2277): >Documentation for User Workload Monitoring implies that default retention time is 15d, when it is actually 24h in practice > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
machine424 commented 7 months ago

nit: I think to be future proof, it's better to explicitly set it to 24h as we do for the the platform one https://github.com/openshift/cluster-monitoring-operator/blob/b60f0b68d49701c55408f0ca96bd4bff06260886/pkg/manifests/config.go#L38 In case we miss the change of the default value in prometheus-operator.

/lgtm /hold unhold when you want.

marioferh commented 7 months ago

/retest-required

danielmellado commented 6 months ago

/lgtm

danielmellado commented 6 months ago

/assign @bburt-rh

danielmellado commented 6 months ago

/retest-required

openshift-ci[bot] commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danielmellado, machine424, marioferh, slashpai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-monitoring-operator/blob/master/OWNERS)~~ [danielmellado,machine424,marioferh,slashpai] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
bburt-rh commented 6 months ago

/label docs-approved

danielmellado commented 6 months ago

@marioferh mind checking @machine424 comment about the hold? I'd like to see if we get this in soon.

machine424 commented 4 months ago

Tell me @marioferh if you want me to take over, Eliska already tried to address this here https://github.com/openshift/cluster-monitoring-operator/pull/2332

simonpasquier commented 4 months ago

/hold cancel

openshift-ci-robot commented 4 months ago

/retest-required

Remaining retests: 0 against base HEAD f47dac6e3b97ada35f2e61b82806ccfbcc817a3a and 2 for PR HEAD dc897bc232d61901d19b4d0c343d06c999696015 in total

openshift-ci[bot] commented 4 months ago

@marioferh: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/versions dc897bc232d61901d19b4d0c343d06c999696015 link false /test versions

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 4 months ago

/retest-required

Remaining retests: 0 against base HEAD a83f250fbf7efd2863a6faab471242322e563796 and 1 for PR HEAD dc897bc232d61901d19b4d0c343d06c999696015 in total

openshift-bot commented 4 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-monitoring-operator-container-v4.17.0-202406052200.p0.g54e469b.assembly.stream.el9 for distgit cluster-monitoring-operator. All builds following this will include this PR.