openshift / cluster-monitoring-operator

Manage the OpenShift monitoring stack
Apache License 2.0
247 stars 363 forks source link

chore: fix metrics-server path for /test versions #2285

Closed rexagod closed 7 months ago

rexagod commented 7 months ago

Owing to the older path being referenced in the prow workflow, we saw consistent failure for /test versions job, this fixes that.

Signed-off-by: Pranshu Srivastava rexagod@gmail.com


openshift-ci[bot] commented 7 months ago

@rexagod: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node 2a5e20f8d4f4cafefbabd6a082b036c059277f14 link false /test e2e-aws-ovn-single-node
ci/prow/versions 2a5e20f8d4f4cafefbabd6a082b036c059277f14 link false /test versions

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
jan--f commented 7 months ago

/lgtm

openshift-ci[bot] commented 7 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jan--f, rexagod

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-monitoring-operator/blob/master/OWNERS)~~ [jan--f,rexagod] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
rexagod commented 7 months ago

/hold PTAL https://github.com/openshift/cluster-monitoring-operator/pull/2252#discussion_r1522882107 for ongoing discussion.

Will unhold once that's addressed.

rexagod commented 7 months ago

/close It seems @slashpai already has a PR up for this: https://github.com/openshift/cluster-monitoring-operator/pull/2252. :)

openshift-ci[bot] commented 7 months ago

@rexagod: Closed this PR.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2285#issuecomment-1994187313): >/close >It seems @slashpai already has a PR up for this: https://github.com/openshift/cluster-monitoring-operator/pull/2252. :) Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
rexagod commented 7 months ago

/reopen Adding additional patches here as a result of https://github.com/openshift/cluster-monitoring-operator/pull/2252#discussion_r1522882107.

openshift-ci[bot] commented 7 months ago

@rexagod: Failed to re-open PR: state cannot be changed. The fix-test-versions branch was force-pushed or recreated.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2285#issuecomment-1995926278): >/reopen >Adding additional patches here as a result of https://github.com/openshift/cluster-monitoring-operator/pull/2252#discussion_r1522882107. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
rexagod commented 7 months ago

Continued here: https://github.com/openshift/cluster-monitoring-operator/pull/2286.