search

openshift / cluster-monitoring-operator

Manage the OpenShift monitoring stack
Apache License 2.0
247 stars 363 forks source link

OCPBUGS-31920: go.mod: bump openshift/api #2290

Closed jan--f closed 6 months ago

jan--f commented 7 months ago

Changes in openshift/api now require us to `import _ "github.com/openshift/api/monitoring/v1/zz_generated.crd-manifests" in order to get the generated CRD manifests in vendor/.

jan--f commented 7 months ago

I came across this on other business and thought we might as well get ahead of things. I'm mostly wondering about the import location. Not sure if adding this to the main package has any unintended consequences.

jan--f commented 7 months ago

/cc @simonpasquier

simonpasquier commented 6 months ago

/lgtm

openshift-ci[bot] commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jan--f, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-monitoring-operator/blob/master/OWNERS)~~ [jan--f,simonpasquier] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
rexagod commented 6 months ago

/retest

openshift-ci-robot commented 6 months ago

@jan--f: This pull request references Jira Issue OCPBUGS-31920, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2290): >Changes in openshift/api now require us to >`import _ "github.com/openshift/api/monitoring/v1/zz_generated.crd-manifests" in order to get the generated CRD manifests in vendor/. > > > >* [ ] I added CHANGELOG entry for this change. >* [ ] No user facing changes, so no entry in CHANGELOG was needed. > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
jan--f commented 6 months ago

/retitle CPBUGS-31920: go.mod: bump openshift/api

openshift-ci-robot commented 6 months ago

@jan--f: No Jira issue with key CPBUGS-31920 exists in the tracker at https://issues.redhat.com/. Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2290): >Changes in openshift/api now require us to >`import _ "github.com/openshift/api/monitoring/v1/zz_generated.crd-manifests" in order to get the generated CRD manifests in vendor/. > > > >* [ ] I added CHANGELOG entry for this change. >* [ ] No user facing changes, so no entry in CHANGELOG was needed. > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 6 months ago

@jan--f: The referenced Jira(s) [CPBUGS-31920] could not be located, all automatically applied jira labels will be removed.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2290): >Changes in openshift/api now require us to >`import _ "github.com/openshift/api/monitoring/v1/zz_generated.crd-manifests" in order to get the generated CRD manifests in vendor/. > > > >* [ ] I added CHANGELOG entry for this change. >* [ ] No user facing changes, so no entry in CHANGELOG was needed. > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
jan--f commented 6 months ago

/retitle OCPBUGS-31920: go.mod: bump openshift/api

openshift-ci-robot commented 6 months ago

@jan--f: This pull request references Jira Issue OCPBUGS-31920, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2290): >Changes in openshift/api now require us to >`import _ "github.com/openshift/api/monitoring/v1/zz_generated.crd-manifests" in order to get the generated CRD manifests in vendor/. > > > >* [ ] I added CHANGELOG entry for this change. >* [ ] No user facing changes, so no entry in CHANGELOG was needed. > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
jan--f commented 6 months ago

/jira refresh

openshift-ci-robot commented 6 months ago

@jan--f: This pull request references Jira Issue OCPBUGS-31920, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.16.0) matches configured target version for branch (4.16.0) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @juzhao

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2290#issuecomment-2045018887): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 6 months ago

@jan--f: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node d8cef7f87c3af367c4c8bc704161cdd909926486 link false /test e2e-aws-ovn-single-node
ci/prow/versions d8cef7f87c3af367c4c8bc704161cdd909926486 link false /test versions

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 6 months ago

@jan--f: Jira Issue OCPBUGS-31920: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-31920 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2290): >Changes in openshift/api now require us to >`import _ "github.com/openshift/api/monitoring/v1/zz_generated.crd-manifests" in order to get the generated CRD manifests in vendor/. > > > >* [ ] I added CHANGELOG entry for this change. >* [ ] No user facing changes, so no entry in CHANGELOG was needed. > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 6 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-monitoring-operator-container-v4.16.0-202404100642.p0.gbf04aae.assembly.stream.el9 for distgit cluster-monitoring-operator. All builds following this will include this PR.