search

openshift / cluster-monitoring-operator

Manage the OpenShift monitoring stack
Apache License 2.0
247 stars 363 forks source link

MON-3749: enable request headers flags for metrics server #2293

Closed slashpai closed 6 months ago

slashpai commented 6 months ago
openshift-ci-robot commented 6 months ago

@slashpai: This pull request references MON-3749 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2293): > > >* [ ] I added CHANGELOG entry for this change. >* [x] No user facing changes, so no entry in CHANGELOG was needed. > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
slashpai commented 6 months ago

will update adding requestheader-client-ca-file as well

danielmellado commented 6 months ago

Small nit, can we squash (unless squash and merge is enabled in CMO repo) these commits before merging this?

slashpai commented 6 months ago

Small nit, can we squash (unless squash and merge is enabled in CMO repo) these commits before merging this?

ya sure I wanted to verify if updated changes works needed to keep separate commit for easy update. First commit is already verified working. I can squash commit once I test the change locally :)

slashpai commented 6 months ago

/skip /retest-required

danielmellado commented 6 months ago

/lgtm

openshift-ci[bot] commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danielmellado, slashpai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-monitoring-operator/blob/master/OWNERS)~~ [danielmellado,slashpai] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
slashpai commented 6 months ago

/hold To clarify a query about mount path

slashpai commented 6 months ago

/hold cancel

slashpai commented 6 months ago

/retest-required

openshift-ci[bot] commented 6 months ago

@slashpai: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node ea9a603e51d34679b7a484a4b4438398ba572a3a link false /test e2e-aws-ovn-single-node
ci/prow/versions ea9a603e51d34679b7a484a4b4438398ba572a3a link false /test versions

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).