Closed tssurya closed 4 months ago
@tssurya: This pull request references SDN-3817 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.
/hold
@tssurya: This pull request references SDN-3817 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.
This pull request references MON-3795 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.17.0" version, but no target version was set.
/hold cancel
@tssurya: This pull request references SDN-3817 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.
This pull request references MON-3795 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.17.0" version, but no target version was set.
/cherry-pick release-4.16
@tssurya: This pull request references SDN-3817 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.
This pull request references MON-3795 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.17.0" version, but no target version was set.
thank you so much Simon for the review!
/cherry-pick release-4.16
@tssurya: once the present PR merges, I will cherry-pick it on top of release-4.16 in a new PR and assign it to you.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: simonpasquier, tssurya
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/retest-required
Remaining retests: 0 against base HEAD 39bc1789be6be3f990afef9c1277bdfaf3e4104f and 2 for PR HEAD 538c2f6bb4b315adebe9efcc49cd000ac084b7e1 in total
/retest-required
/label qe-approved
@tssurya: This pull request references SDN-3817 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target either version "4.17." or "openshift-4.17.", but it targets "4.16.0" instead.
This pull request references MON-3795 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target either version "4.17." or "openshift-4.17.", but it targets "openshift-4.16" instead.
/label px-approved
@tssurya: all tests passed!
Full PR test history. Your PR dashboard.
@tssurya: #2297 failed to apply on top of branch "release-4.16":
Applying: Expose OVNKubernetes:AdminNetworkPolicy Metrics via telemetry
Using index info to reconstruct a base tree...
M Documentation/data-collection.md
M Documentation/sample-metrics.md
M Documentation/telemetry/telemeter_query
M manifests/0000_50_cluster-monitoring-operator_04-config.yaml
Falling back to patching base and 3-way merge...
Auto-merging manifests/0000_50_cluster-monitoring-operator_04-config.yaml
Auto-merging Documentation/telemetry/telemeter_query
CONFLICT (content): Merge conflict in Documentation/telemetry/telemeter_query
Auto-merging Documentation/sample-metrics.md
CONFLICT (content): Merge conflict in Documentation/sample-metrics.md
Auto-merging Documentation/data-collection.md
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Expose OVNKubernetes:AdminNetworkPolicy Metrics via telemetry
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
/label doc-approved
/label docs-approved
@JoeAldinger: The label(s) /label doc-approved
cannot be applied. These labels are supported: acknowledge-critical-fixes-only, platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, no-qe, downstream-change-needed, rebase/manual, cluster-config-api-changed, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, jira/valid-bug, staff-eng-approved
. Is this label configured under labels -> additional_labels
or labels -> restricted_labels
in plugin.yaml
?
[ART PR BUILD NOTIFIER]
This PR has been included in build cluster-monitoring-operator-container-v4.17.0-202406102247.p0.g7015893.assembly.stream.el9 for distgit cluster-monitoring-operator. All builds following this will include this PR.
Fix included in accepted release 4.16.0-0.nightly-2024-07-04-084325
Changelog will go into the 4.16 backport PR since that's what it will be introduced first. So after this merges and I open a backport I will add it there. This is very much a user facing change.