search

openshift / cluster-monitoring-operator

Manage the OpenShift monitoring stack
Apache License 2.0
247 stars 363 forks source link

OCPBUGS-32055: backport ols metric allowlist to 4.15 #2313

Closed bparees closed 6 months ago

bparees commented 6 months ago
openshift-bot commented 6 months ago

@bparees: This pull request references MON-3810 which is a valid jira issue.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2313): > > >* [ ] I added CHANGELOG entry for this change. >* [x] No user facing changes, so no entry in CHANGELOG was needed. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 6 months ago

@bparees: This pull request references Jira Issue OCPBUGS-32055, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2313): > > >* [ ] I added CHANGELOG entry for this change. >* [x] No user facing changes, so no entry in CHANGELOG was needed. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
bparees commented 6 months ago

manually labeling to valid bug as there is/was/will be no 4.16+ bug since the fix merged to main prior to branching for those releases. (and this isn't really a bug)

juzhao commented 6 months ago

@bparees I am afraid you also need to add these metrics to teletmer-server side, did not see these metrics in https://github.com/rhobs/configuration/blob/main/configuration/telemeter/metrics.json then you won't be able to query these metrics from telemeter server

bparees commented 6 months ago

@bparees I am afraid you also need to add these metrics to teletmer-server side, did not see these metrics in https://github.com/rhobs/configuration/blob/main/configuration/telemeter/metrics.json then you won't be able to query these metrics from telemeter server

thanks i'll do that next but i don't think it precludes merging this backport, does it?

juzhao commented 6 months ago

thanks i'll do that next but i don't think it precludes merging this backport, does it?

no, it won't prevent merging this PR, only prevent searching these metrics from telemeter server

bparees commented 6 months ago

/retest

bparees commented 6 months ago

@simonpasquier @jan--f ptal

jan--f commented 6 months ago

/lgtm /label backport-risk-assessed

openshift-ci[bot] commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, jan--f

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-monitoring-operator/blob/release-4.15/OWNERS)~~ [jan--f] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 6 months ago

@bparees: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 6 months ago

@bparees: Jira Issue OCPBUGS-32055: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-32055 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2313): > > >* [ ] I added CHANGELOG entry for this change. >* [x] No user facing changes, so no entry in CHANGELOG was needed. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 6 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-monitoring-operator-container-v4.15.0-202404161612.p0.g00d04f5.assembly.stream.el9 for distgit cluster-monitoring-operator. All builds following this will include this PR.