search

openshift / cluster-monitoring-operator

Manage the OpenShift monitoring stack
Apache License 2.0
247 stars 363 forks source link

MON-3814: Follow-up #2293 #2315

Closed slashpai closed 3 weeks ago

slashpai commented 6 months ago

Follow-up from https://github.com/openshift/cluster-monitoring-operator/pull/2293

openshift-bot commented 6 months ago

@slashpai: This pull request references MON-3814 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2315): >Follow-up from https://github.com/openshift/cluster-monitoring-operator/pull/2293 > >* [ ] I added CHANGELOG entry for this change. >* [ ] No user facing changes, so no entry in CHANGELOG was needed. > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: slashpai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-monitoring-operator/blob/master/OWNERS)~~ [slashpai] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
slashpai commented 6 months ago

/assign @machine424

slashpai commented 5 months ago

Closing in favour of https://github.com/openshift/cluster-monitoring-operator/pull/2329

slashpai commented 5 months ago

/close

openshift-ci[bot] commented 5 months ago

@slashpai: Closed this PR.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2315#issuecomment-2074276959): >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
machine424 commented 5 months ago

Because we put https://github.com/openshift/cluster-monitoring-operator/pull/2329 on hold for now, we can revive this PR if you want.

machine424 commented 4 months ago

I'll /reopen this, it'll be nice to have this cleaning in 4.17

openshift-ci[bot] commented 4 months ago

@machine424: Reopened this PR.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2315#issuecomment-2149656457): >I'll >/reopen >this, it'll be nice to have this cleaning in 4.17 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 4 months ago

@slashpai: This pull request references MON-3814 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2315): >Follow-up from https://github.com/openshift/cluster-monitoring-operator/pull/2293 > >* [ ] I added CHANGELOG entry for this change. >* [ ] No user facing changes, so no entry in CHANGELOG was needed. > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
machine424 commented 4 months ago

I think we can merge this once tlsSecret is dropped as an argument to MetricsServerSecret.

machine424 commented 4 months ago

/hold

slashpai commented 3 weeks ago

/close

openshift-ci[bot] commented 3 weeks ago

@slashpai: Closed this PR.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2315#issuecomment-2376094612): >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.