search

openshift / cluster-monitoring-operator

Manage the OpenShift monitoring stack
Apache License 2.0
247 stars 363 forks source link

WIP DO NOT MERGE [only testing]: Test Metrics Server Feature Gate Default #2317

Closed slashpai closed 6 months ago

slashpai commented 6 months ago

/hold

This PR is only meant to test if switching Metrics Server to default breaks test original PR to update api is https://github.com/openshift/api/pull/1851. For testing purpose I replaced to my fork

may be this will also need to update other libs (CCO) I am not sure but creating a WIP PR to see

cc: @simonpasquier

openshift-ci[bot] commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: slashpai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-monitoring-operator/blob/master/OWNERS)~~ [slashpai] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
slashpai commented 6 months ago

/retest

slashpai commented 6 months ago

I think we need change to cluster config operator as well to get the change since it's still not turned to default even after bumping api to fork

openshift-ci[bot] commented 6 months ago

@slashpai: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn df858aa33cf433daff189c5ed274d9e2a2e7bf89 link true /test e2e-aws-ovn
ci/prow/jsonnet-fmt df858aa33cf433daff189c5ed274d9e2a2e7bf89 link true /test jsonnet-fmt

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).