Closed simonpasquier closed 6 months ago
@simonpasquier: This pull request references MON-3071 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.
/cc @machine424
/hold
Cool, IIUC you're waiting for https://github.com/openshift/cluster-monitoring-operator/blob/386067902fbc8faa82baf73fe8b7591270e47cee/test/e2e/thanos_querier_test.go#L75 to fail now that you've adjusted the util?
@simonpasquier: This pull request references MON-3701 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.
@simonpasquier: all tests passed!
Full PR test history. Your PR dashboard.
Should we wait for https://github.com/openshift/cluster-monitoring-operator/pull/2325/files? /hold unhold if not /lgtm Thanks Simon.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: machine424, simonpasquier
The full list of commands accepted by this bot can be found here.
The pull request process is described here
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: machine424, simonpasquier
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/hold cancel
From https://github.com/openshift/cluster-monitoring-operator/pull/2308#pullrequestreview-1997013955