openshift / cluster-monitoring-operator

Manage the OpenShift monitoring stack
Apache License 2.0
247 stars 363 forks source link

MON-3701: remove trusted CA bundle from Thanos Querier #2325

Closed simonpasquier closed 6 months ago

simonpasquier commented 6 months ago

The trusted CA bundle was only used by the OAuth proxy container to verify the OAuth server certificate. OAuth proxy is now removed and replaced by kube-rbac-proxy hence there's no need to keep the trusted CA configmap around.

openshift-ci-robot commented 6 months ago

@simonpasquier: This pull request references MON-3071 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2325): >The trusted CA bundle was only used by the OAuth proxy container to verify the OAuth server certificate. OAuth proxy is now removed and replaced by kube-rbac-proxy hence there's no need to keep the trusted CA configmap around. > > > >* [ ] I added CHANGELOG entry for this change. >* [ ] No user facing changes, so no entry in CHANGELOG was needed. > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 6 months ago

@simonpasquier: This pull request references MON-3701 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2325): >The trusted CA bundle was only used by the OAuth proxy container to verify the OAuth server certificate. OAuth proxy is now removed and replaced by kube-rbac-proxy hence there's no need to keep the trusted CA configmap around. > > > >* [ ] I added CHANGELOG entry for this change. >* [x] No user facing changes, so no entry in CHANGELOG was needed. > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
rexagod commented 6 months ago

/lgtm

openshift-ci[bot] commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rexagod, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-monitoring-operator/blob/master/OWNERS)~~ [rexagod,simonpasquier] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 6 months ago

/retest-required

Remaining retests: 0 against base HEAD f7ab64d78c8f467de3025346dfe7c07637215892 and 2 for PR HEAD f0dea72dd9e387f0239410a3d17a5fb2ca4a6507 in total

openshift-ci[bot] commented 6 months ago

@simonpasquier: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-bot commented 6 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-monitoring-operator-container-v4.16.0-202404181209.p0.g65ee646.assembly.stream.el9 for distgit cluster-monitoring-operator. All builds following this will include this PR.