openshift / cluster-monitoring-operator

Manage the OpenShift monitoring stack
Apache License 2.0
247 stars 363 forks source link

MON-3839: test: add skip tests for prometheus adapter tests #2328

Closed slashpai closed 6 months ago

slashpai commented 6 months ago
openshift-ci-robot commented 6 months ago

@slashpai: This pull request references MON-3839 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2328): > > >* [ ] I added CHANGELOG entry for this change. >* [x] No user facing changes, so no entry in CHANGELOG was needed. > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
slashpai commented 6 months ago

/hold

slashpai commented 6 months ago

/hold cancel

jan--f commented 6 months ago

/lgtm

jan--f commented 6 months ago

/retest

slashpai commented 6 months ago

ok I need to remove prometheus-adapter from metrics map when feature gate is enabled

prometheus_test.go:53: context deadline exceeded: error getting first value from response body "{\"status\":\"success\",\"data\":{\"resultType\":\"vector\",\"result\":[],\"analysis\":{}}}\n" for query "count(up{service=\"prometheus-adapter\",namespace=\"openshift-monitoring\"} == 1)": expected body to contain single timeseries but got 0
--- FAIL: TestPrometheusMetrics (645.17s)
    --- PASS: TestPrometheusMetrics/metrics-server (5.01s)
    --- FAIL: TestPrometheusMetrics/prometheus-adapter (600.02s)
jan--f commented 6 months ago

Ahh right, WaitForQueryReturn can't deal with no result.

slashpai commented 6 months ago

@jan--f please review again updated

jan--f commented 6 months ago

/lgtm

openshift-ci[bot] commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jan--f, slashpai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-monitoring-operator/blob/master/OWNERS)~~ [jan--f,slashpai] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
danielmellado commented 6 months ago

/skip

openshift-ci[bot] commented 6 months ago

@slashpai: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node 9bf5bf61d91f2c34d830a48c9a267180ce5e18ef link false /test e2e-aws-ovn-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).