Closed slashpai closed 6 months ago
@slashpai: This pull request references MON-3839 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.
/hold
/hold cancel
/lgtm
/retest
ok I need to remove prometheus-adapter from metrics map when feature gate is enabled
prometheus_test.go:53: context deadline exceeded: error getting first value from response body "{\"status\":\"success\",\"data\":{\"resultType\":\"vector\",\"result\":[],\"analysis\":{}}}\n" for query "count(up{service=\"prometheus-adapter\",namespace=\"openshift-monitoring\"} == 1)": expected body to contain single timeseries but got 0
--- FAIL: TestPrometheusMetrics (645.17s)
--- PASS: TestPrometheusMetrics/metrics-server (5.01s)
--- FAIL: TestPrometheusMetrics/prometheus-adapter (600.02s)
Ahh right, WaitForQueryReturn
can't deal with no result.
@jan--f please review again updated
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jan--f, slashpai
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/skip
@slashpai: The following test failed, say /retest
to rerun all failed tests or /retest-required
to rerun all mandatory failed tests:
Test name | Commit | Details | Required | Rerun command |
---|---|---|---|---|
ci/prow/e2e-aws-ovn-single-node | 9bf5bf61d91f2c34d830a48c9a267180ce5e18ef | link | false | /test e2e-aws-ovn-single-node |
Full PR test history. Your PR dashboard.