openshift / cluster-monitoring-operator

Manage the OpenShift monitoring stack
Apache License 2.0
247 stars 363 forks source link

MON-3838: Synchronize versions of the downstream components #2331

Closed openshift-monitoring-bot[bot] closed 5 months ago

openshift-monitoring-bot[bot] commented 5 months ago

Description

This pull request updates jsonnet/versions.yaml to match with the already in use downstream versions of the monitoring components.

Based on that file, it regenerates the assets to update some metadata (mainly the app.kubernetes.io/version annotation) attached to some of the resources and update other placeholders.

It is safe to merge this change (provided that the CI jobs pass).

If you wish to perform this manually, execute the following commands from cluster-monitoring-operator repository:

make versions
make generate
openshift-ci[bot] commented 5 months ago

Hi @openshift-monitoring-bot[bot]. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
jan--f commented 5 months ago

/hold this is in #2078. Let;s try to not create another merge conflict there.

openshift-ci[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-monitoring-bot[bot], slashpai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-monitoring-operator/blob/master/OWNERS)~~ [slashpai] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
slashpai commented 5 months ago

I see this is already been covered in https://github.com/openshift/cluster-monitoring-operator/pull/2078 so if that gets merged this PR can be closed

openshift-ci[bot] commented 5 months ago

@openshift-monitoring-bot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node 92951b365db750666342a8f3dd0694937948cdfe link false /test e2e-aws-ovn-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
simonpasquier commented 5 months ago

/retest-required

simonpasquier commented 5 months ago

/hold cancel

simonpasquier commented 5 months ago

/retitle MON-3838: Synchronize versions of the downstream components

openshift-ci-robot commented 5 months ago

@openshift-monitoring-bot[bot]: This pull request references MON-3838 which is a valid jira issue.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2331): >## Description >This pull request updates `jsonnet/versions.yaml` to match with the **already in use** downstream versions of the monitoring components. > >Based on that file, it regenerates the assets to update some metadata (mainly the `app.kubernetes.io/version` annotation) attached to some of the resources and update other placeholders. > >**It is safe to merge this change (provided that the CI jobs pass).** > >If you wish to perform this manually, execute the following commands from cluster-monitoring-operator repository: >``` >make versions >make generate >``` Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
simonpasquier commented 5 months ago

/retest-required

simonpasquier commented 5 months ago

/close trying to unblock the tide job.

openshift-ci[bot] commented 5 months ago

@simonpasquier: Closed this PR.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2331#issuecomment-2092453248): >/close >trying to unblock the tide job. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
simonpasquier commented 5 months ago

/reopen

openshift-ci[bot] commented 5 months ago

@simonpasquier: Failed to re-open PR: state cannot be changed. The automated-updates-master-versions-generate branch was force-pushed or recreated.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2331#issuecomment-2093061110): >/reopen Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.