search

openshift / cluster-monitoring-operator

Manage the OpenShift monitoring stack
Apache License 2.0
247 stars 363 forks source link

OBSDOCS-883: Fix the wrong retention time comment for user-defined project monitoring #2332

Closed eromanova97 closed 5 months ago

eromanova97 commented 5 months ago

Issue: OBSDOCS-883

This is to fix the wrong comment about retention time for user-defined project monitoring.

openshift-ci-robot commented 5 months ago

@eromanova97: This pull request references OBSDOCS-883 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2332): >Issue: [OBSDOCS-883](https://issues.redhat.com/browse/OBSDOCS-883) > >This is to fix the wrong comment about retention time for user-defined project monitoring. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: eromanova97 Once this PR has been reviewed and has the lgtm label, please assign marioferh for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/cluster-monitoring-operator/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 5 months ago

@eromanova97: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-techpreview aef5d29500a1307203eddb3e294fa21a74f54f74 link true /test e2e-aws-ovn-techpreview
ci/prow/generate aef5d29500a1307203eddb3e294fa21a74f54f74 link true /test generate
ci/prow/e2e-aws-ovn-upgrade aef5d29500a1307203eddb3e294fa21a74f54f74 link true /test e2e-aws-ovn-upgrade
ci/prow/e2e-aws-ovn-single-node aef5d29500a1307203eddb3e294fa21a74f54f74 link false /test e2e-aws-ovn-single-node
ci/prow/e2e-aws-ovn aef5d29500a1307203eddb3e294fa21a74f54f74 link true /test e2e-aws-ovn
ci/prow/versions aef5d29500a1307203eddb3e294fa21a74f54f74 link false /test versions
ci/prow/e2e-agnostic-operator aef5d29500a1307203eddb3e294fa21a74f54f74 link true /test e2e-agnostic-operator

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
machine424 commented 5 months ago

note that we already have a similar PR: https://github.com/openshift/cluster-monitoring-operator/pull/2277

eromanova97 commented 5 months ago

note that we already have a similar PR: #2277

Thank you for letting me know, I missed that one. I will close this PR then.