search

openshift / cluster-monitoring-operator

Manage the OpenShift monitoring stack
Apache License 2.0
247 stars 363 forks source link

OCPBUGS-32510: tweak Prometheus RBAC setup as a temp fix. #2334

Closed machine424 closed 5 months ago

machine424 commented 5 months ago

OCPBUGS-32510: adapt the metrics-server readiness probe config.

See the added comments and https://docs.google.com/document/d/1VpGBbV30-bb-eq-JYi2q5B8Hyll37tp30OrHcnCifpo/edit?usp=sharing for more details

/cc @slashpai /cc @simonpasquier

openshift-ci-robot commented 5 months ago

@machine424: This pull request references Jira Issue OCPBUGS-32510, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.16.0) matches configured target version for branch (4.16.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @juzhao

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2334): >OCPBUGS-32510: adapt the metrics-server readiness probe config. > >See the added comments and https://docs.google.com/document/d/1VpGBbV30-bb-eq-JYi2q5B8Hyll37tp30OrHcnCifpo/edit?usp=sharing for more details > > > >* [ ] I added CHANGELOG entry for this change. >* [ ] No user facing changes, so no entry in CHANGELOG was needed. > >/cc @slashpai >/cc @simonpasquier Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
machine424 commented 5 months ago

/payload-job-with-prs periodic-ci-openshift-hypershift-release-4.16-periodics-e2e-aws-ovn-conformance openshift/api#1865

openshift-ci[bot] commented 5 months ago

@machine424: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/f690e7b0-061b-11ef-9fd2-47a92bba20d9-0

machine424 commented 5 months ago

/payload-job-with-prs periodic-ci-openshift-release-master-nightly-4.16-e2e-aws-ovn-single-node openshift/api#1865

openshift-ci[bot] commented 5 months ago

@machine424: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/076427f0-061c-11ef-9ef0-5fb887b41964-0

machine424 commented 5 months ago

/payload-job-with-prs periodic-ci-openshift-release-master-ci-4.16-e2e-aws-ovn openshift/api#1865

openshift-ci[bot] commented 5 months ago

@machine424: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/4fbb7170-061c-11ef-8f50-6f9c4ffaf8f8-0

openshift-ci[bot] commented 5 months ago

@machine424: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/versions 1fc3e3a2fed47750768a05e1234b3d957ec8e19f link false /test versions

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
simonpasquier commented 5 months ago

/skip

machine424 commented 5 months ago

/payload-job-with-prs periodic-ci-openshift-release-master-nightly-4.16-e2e-aws-ovn-single-node openshift/api#1865,openshift/kubernetes-metrics-server#26,openshift/kubernetes#1960,openshift/machine-config-operator#4338

openshift-ci[bot] commented 5 months ago

@machine424: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info.

machine424 commented 5 months ago

/payload-job-with-prs periodic-ci-openshift-release-master-nightly-4.16-e2e-aws-ovn-single-node openshift/api#1865 openshift/kubernetes-metrics-server#26 openshift/kubernetes#1960 openshift/machine-config-operator#4338

openshift-ci[bot] commented 5 months ago

@machine424: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/03f35510-0896-11ef-802d-50a22c76e308-0

machine424 commented 5 months ago

(The command run above shouldn't block the PR, it's for further debugging)

machine424 commented 5 months ago

/payload-job-with-prs periodic-ci-openshift-release-master-nightly-4.16-e2e-aws-ovn-single-node openshift/api#1865 openshift/kubernetes-metrics-server#26 openshift/kubernetes#1960 openshift/machine-config-operator#4338

openshift-ci[bot] commented 5 months ago

@machine424: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/d9525760-089b-11ef-9975-d22b2f658399-0

machine424 commented 5 months ago

/payload-job-with-prs periodic-ci-openshift-release-master-nightly-4.16-e2e-aws-ovn-single-node openshift/api#1865 openshift/kubernetes-metrics-server#26 openshift/kubernetes#1960 openshift/machine-config-operator#4338

openshift-ci[bot] commented 5 months ago

@machine424: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/8e57e7a0-091a-11ef-938e-27baa3eaae5d-0

machine424 commented 5 months ago

/payload-job-with-prs periodic-ci-openshift-release-master-nightly-4.16-e2e-aws-ovn-single-node openshift/api#1865 openshift/kubernetes-metrics-server#26 openshift/kubernetes#1960 openshift/machine-config-operator#4338

openshift-ci[bot] commented 5 months ago

@machine424: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/8c828630-092c-11ef-9a2d-618f2d601a8f-0

machine424 commented 5 months ago

/payload-job-with-prs periodic-ci-openshift-release-master-nightly-4.16-e2e-aws-ovn-single-node openshift/api#1878 openshift/kubernetes-metrics-server#26 openshift/kubernetes#1960

openshift-ci[bot] commented 5 months ago

@machine424: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/7edfae70-0965-11ef-9e7d-f89ee8db2303-0

slashpai commented 5 months ago

/payload-job-with-prs periodic-ci-openshift-release-master-nightly-4.16-e2e-aws-ovn-single-node openshift/api#1865

openshift-ci[bot] commented 5 months ago

@slashpai: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/d0cc0670-096a-11ef-9dbc-acfab9cb5559-0

slashpai commented 5 months ago

/payload-job-with-prs periodic-ci-openshift-hypershift-release-4.16-periodics-e2e-aws-ovn-conformance openshift/api#1865

openshift-ci[bot] commented 5 months ago

@slashpai: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/f6994d40-096a-11ef-92d9-e176bdd904a1-0

machine424 commented 5 months ago

/payload-job-with-prs periodic-ci-openshift-release-master-nightly-4.16-e2e-aws-ovn-single-node openshift/api#1878 openshift/kubernetes-metrics-server#26 openshift/kubernetes#1960

openshift-ci[bot] commented 5 months ago

@machine424: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/56fe3270-0b7a-11ef-8f34-6b42ed678a2f-0

slashpai commented 5 months ago

/lgtm

openshift-ci[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: machine424, simonpasquier, slashpai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-monitoring-operator/blob/master/OWNERS)~~ [machine424,simonpasquier,slashpai] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
simonpasquier commented 5 months ago

/hold cancel

openshift-ci-robot commented 5 months ago

@machine424: Jira Issue OCPBUGS-32510: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-32510 has not been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2334): >OCPBUGS-32510: adapt the metrics-server readiness probe config. > >See the added comments and https://docs.google.com/document/d/1VpGBbV30-bb-eq-JYi2q5B8Hyll37tp30OrHcnCifpo/edit?usp=sharing for more details > > > >* [ ] I added CHANGELOG entry for this change. >* [ ] No user facing changes, so no entry in CHANGELOG was needed. > >/cc @slashpai >/cc @simonpasquier Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 5 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-monitoring-operator-container-v4.17.0-202405061412.p0.g93a4599.assembly.stream.el9 for distgit cluster-monitoring-operator. All builds following this will include this PR.