search

openshift / cluster-monitoring-operator

Manage the OpenShift monitoring stack
Apache License 2.0
247 stars 363 forks source link

MON-3851: Bump openshift/thanos to v0.35.0 #2338

Closed openshift-monitoring-bot[bot] closed 5 months ago

openshift-monitoring-bot[bot] commented 5 months ago

Description

This pull request updates jsonnet/versions.yaml to match with the already in use downstream versions of the monitoring components.

Based on that file, it regenerates the assets to update some metadata (mainly the app.kubernetes.io/version annotation) attached to some of the resources and update other placeholders.

It is safe to merge this change (provided that the CI jobs pass).

If you wish to perform this manually, execute the following commands from cluster-monitoring-operator repository:

make versions
make generate
simonpasquier commented 5 months ago

/retitle MON-3851: Bump openshift/thanos to v0.35.0 /lgtm /approve

openshift-ci-robot commented 5 months ago

@openshift-monitoring-bot[bot]: This pull request references MON-3851 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2338): >## Description >This pull request updates `jsonnet/versions.yaml` to match with the **already in use** downstream versions of the monitoring components. > >Based on that file, it regenerates the assets to update some metadata (mainly the `app.kubernetes.io/version` annotation) attached to some of the resources and update other placeholders. > >**It is safe to merge this change (provided that the CI jobs pass).** > >If you wish to perform this manually, execute the following commands from cluster-monitoring-operator repository: >``` >make versions >make generate >``` Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-monitoring-bot[bot], simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-monitoring-operator/blob/master/OWNERS)~~ [simonpasquier] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 5 months ago

Hi @openshift-monitoring-bot[bot]. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
simonpasquier commented 5 months ago

/skip

openshift-ci[bot] commented 5 months ago

@openshift-monitoring-bot[bot]: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node 7cabe503cceb681762c1849a3e64d12a33af466e link false /test e2e-aws-ovn-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-bot commented 5 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-monitoring-operator-container-v4.16.0-202405071820.p0.g6c9136a.assembly.stream.el9 for distgit cluster-monitoring-operator. All builds following this will include this PR.