Closed weirdwiz closed 15 hours ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: weirdwiz Once this PR has been reviewed and has the lgtm label, please assign danielmellado for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Hi @weirdwiz. Thanks for your PR.
I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
Thanks for this.
Do we have a guarantee that no <4.12
cluster is sending this metric anymore?
IIUC, there is no versioning on telemeter server side: https://github.com/rhobs/configuration/blob/d2353fb83f94d23a173f56b93a5329e5f85c9e13/Makefile#L110-L115 (server's allow list uses CMO's maqter)
If we remove this metric here, we may prevent those old clusters from sending it.
I think, if it's just a clean-up change, it's safer to keep things as they are.
Maybe we could mention that next to these "deprecated" comments.
Of course, if you DO want this metric to disappear, that's another discussion. cc @jan--f @simonpasquier
+1 to what Ayoub said. Dropping the metric from this list means that it will be rejected on the telemeter server side. It might be better to document the metric as being deprecated and remove it once it's not available in any supported OCP version. Anyway thanks for the clean-up!
Issues go stale after 90d of inactivity.
Mark the issue as fresh by commenting /remove-lifecycle stale
.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen
.
If this issue is safe to close now please do so with /close
.
/lifecycle stale
PR needs rebase.
Stale issues rot after 30d of inactivity.
Mark the issue as fresh by commenting /remove-lifecycle rotten
.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen
.
If this issue is safe to close now please do so with /close
.
/lifecycle rotten /remove-lifecycle stale
Rotten issues close after 30d of inactivity.
Reopen the issue by commenting /reopen
.
Mark the issue as fresh by commenting /remove-lifecycle rotten
.
Exclude this issue from closing again by commenting /lifecycle frozen
.
/close
@openshift-bot: Closed this PR.
This commit removes job:kube_pv:count from telemetry as it's been deprecated and no longer contains any value