search

openshift / cluster-monitoring-operator

Manage the OpenShift monitoring stack
Apache License 2.0
247 stars 363 forks source link

WIP: MON-3868: Crd based watch events #2350

Open marioferh opened 5 months ago

openshift-ci[bot] commented 5 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

openshift-ci[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marioferh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-monitoring-operator/blob/master/OWNERS)~~ [marioferh] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
marioferh commented 5 months ago

/retest

marioferh commented 5 months ago

change to go 1.22, otherwise code-generator does not work. We can wait until bump to go 1.22 or try to fix code generator with 1.21

marioferh commented 5 months ago

/retest-required

openshift-ci-robot commented 5 months ago

@marioferh: This pull request references MON-3868 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2350): > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 3 months ago

@marioferh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/generate 2eb17ab213444166db04059ca72ecfdbcf26f925 link true /test generate
ci/prow/e2e-agnostic-operator 2eb17ab213444166db04059ca72ecfdbcf26f925 link true /test e2e-agnostic-operator
ci/prow/golangci-lint 2eb17ab213444166db04059ca72ecfdbcf26f925 link true /test golangci-lint
ci/prow/rules 2eb17ab213444166db04059ca72ecfdbcf26f925 link true /test rules
ci/prow/e2e-aws-ovn-single-node 2eb17ab213444166db04059ca72ecfdbcf26f925 link false /test e2e-aws-ovn-single-node
ci/prow/e2e-aws-ovn 2eb17ab213444166db04059ca72ecfdbcf26f925 link true /test e2e-aws-ovn
ci/prow/verify 2eb17ab213444166db04059ca72ecfdbcf26f925 link true /test verify
ci/prow/jsonnet-fmt 2eb17ab213444166db04059ca72ecfdbcf26f925 link true /test jsonnet-fmt
ci/prow/e2e-aws-ovn-upgrade 2eb17ab213444166db04059ca72ecfdbcf26f925 link true /test e2e-aws-ovn-upgrade
ci/prow/e2e-aws-ovn-techpreview 2eb17ab213444166db04059ca72ecfdbcf26f925 link true /test e2e-aws-ovn-techpreview
ci/prow/versions 2eb17ab213444166db04059ca72ecfdbcf26f925 link false /test versions
ci/prow/e2e-hypershift-conformance 2eb17ab213444166db04059ca72ecfdbcf26f925 link true /test e2e-hypershift-conformance

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-merge-robot commented 3 months ago

PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-merge-robot commented 3 months ago

PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-merge-robot commented 3 months ago

PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-merge-robot commented 3 months ago

PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-bot commented 2 weeks ago

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale