search

openshift / cluster-monitoring-operator

Manage the OpenShift monitoring stack
Apache License 2.0
247 stars 363 forks source link

OCPBUGS-32696: opt-out of multi-cluster Prometheus dashboard #2351

Closed rexagod closed 4 months ago

rexagod commented 5 months ago

Addresses the Prometheus dashboard showing up empty in console.

Visuals Screenshot 2024-05-16 at 2 52 00 AM
openshift-ci-robot commented 5 months ago

@rexagod: This pull request references Jira Issue OCPBUGS-32696, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2351): >Addresses the Prometheus dashboard showing up empty in console. >*** >* [ ] I added CHANGELOG entry for this change. >* [x] No user facing changes, so no entry in CHANGELOG was needed. > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
rexagod commented 5 months ago

/jira refresh

openshift-ci-robot commented 5 months ago

@rexagod: This pull request references Jira Issue OCPBUGS-32696, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.16.0) matches configured target version for branch (4.16.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @juzhao

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2351#issuecomment-2113463335): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
jan--f commented 5 months ago

/lgtm

openshift-ci[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jan--f, rexagod

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-monitoring-operator/blob/master/OWNERS)~~ [jan--f,rexagod] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-bot commented 5 months ago

/jira refresh

The requirements for Jira bugs have changed (Jira issues linked to PRs on main branch need to target different OCP), recalculating validity.

openshift-ci-robot commented 5 months ago

@openshift-bot: This pull request references Jira Issue OCPBUGS-32696, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2351#issuecomment-2117803726): >/jira refresh > >The requirements for Jira bugs have changed (Jira issues linked to PRs on main branch need to target different OCP), recalculating validity. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
juzhao commented 5 months ago

updated "Target Version"to 4.17.0 /jira refresh

openshift-ci-robot commented 5 months ago

@juzhao: This pull request references Jira Issue OCPBUGS-32696, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.17.0) matches configured target version for branch (4.17.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @juzhao

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2351#issuecomment-2119723869): >updated "Target Version"to 4.17.0 >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
juzhao commented 5 months ago

/label qe-approved

rexagod commented 5 months ago

/cherrypick release-4.16

openshift-cherrypick-robot commented 5 months ago

@rexagod: once the present PR merges, I will cherry-pick it on top of release-4.16 in a new PR and assign it to you.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2351#issuecomment-2122022003): >/cherrypick release-4.16 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 5 months ago

/retest-required

Remaining retests: 0 against base HEAD 0eb445c4f74892faab2191f26fb415f20d5575be and 2 for PR HEAD d24199c78a488924f4a213ad23cd7421a68c2c80 in total

openshift-ci-robot commented 5 months ago

/retest-required

Remaining retests: 0 against base HEAD db006a94385df720f1351b2dae636b53e40a271c and 1 for PR HEAD d24199c78a488924f4a213ad23cd7421a68c2c80 in total

rexagod commented 5 months ago

/hold

Will unhold after clarifying some concerns with Jan.

rexagod commented 4 months ago

/unhold

openshift-ci[bot] commented 4 months ago

@rexagod: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 4 months ago

@rexagod: Jira Issue OCPBUGS-32696: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-32696 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2351): >Addresses the Prometheus dashboard showing up empty in console. > >
>Visuals > >Screenshot 2024-05-16 at 2 52 00 AM > >
  • [ ] I added CHANGELOG entry for this change.
  • [x] No user facing changes, so no entry in CHANGELOG was needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-bot commented 4 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-monitoring-operator-container-v4.17.0-202406210743.p0.gc12b3f4.assembly.stream.el9 for distgit cluster-monitoring-operator. All builds following this will include this PR.

rexagod commented 4 months ago

/cherrypick release-4.16

It seems https://github.com/openshift/cluster-monitoring-operator/pull/2351#issuecomment-2122022003 didn't trigger a PR creation.

openshift-cherrypick-robot commented 4 months ago

@rexagod: new pull request created: #2391

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2351#issuecomment-2182302524): >/cherrypick release-4.16 > >It seems https://github.com/openshift/cluster-monitoring-operator/pull/2351#issuecomment-2122022003 didn't trigger a PR creation. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.