MON-3701: clean-up injection of CA bundle for user Alertmanager - Githubissues

openshift / cluster-monitoring-operator

Manage the OpenShift monitoring stack

Apache License 2.0

247 stars 363 forks source link

MON-3701: clean-up injection of CA bundle for user Alertmanager #2361

Closed simonpasquier closed 4 months ago

simonpasquier commented 5 months ago

[ ] I added CHANGELOG entry for this change.
[x] No user facing changes, so no entry in CHANGELOG was needed.

openshift-ci-robot commented 5 months ago

@simonpasquier: This pull request references MON-3701 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2361): > > >* [ ] I added CHANGELOG entry for this change. >* [ ] No user facing changes, so no entry in CHANGELOG was needed. > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

simonpasquier commented 5 months ago

/hold waiting for https://github.com/openshift/cluster-monitoring-operator/pull/2349 first

simonpasquier commented 5 months ago

/skip

simonpasquier commented 4 months ago

/hold cancel

simonpasquier commented 4 months ago

/skip

simonpasquier commented 4 months ago

/retest-required

simonpasquier commented 4 months ago

/skip

simonpasquier commented 4 months ago

/retest-required

openshift-ci[bot] commented 4 months ago

@simonpasquier: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-ovn-single-node	fbc7eca5db468f7331e948e954767f7ecaecbc02	link	false	`/test e2e-aws-ovn-single-node`
ci/prow/versions	fbc7eca5db468f7331e948e954767f7ecaecbc02	link	false	`/test versions`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).

machine424 commented 4 months ago

/lgtm

openshift-ci[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: machine424, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-monitoring-operator/blob/master/OWNERS)~~ [machine424,simonpasquier] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

openshift-bot commented 4 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-monitoring-operator-container-v4.17.0-202405291241.p0.g3432869.assembly.stream.el9 for distgit cluster-monitoring-operator. All builds following this will include this PR.