[release-4.16] OCPBUGS-34806: send cnv_abnormal metric via telemetry

openshift-cherrypick-robot commented 5 months ago

This is an automated cherry-pick of #2291

/assign avlitman

openshift-ci-robot commented 5 months ago

@openshift-cherrypick-robot: Ignoring requests to cherry-pick non-bug issues: MON-3763

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2364): >This is an automated cherry-pick of #2291 > >/assign avlitman Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

juzhao commented 4 months ago

/test e2e-aws-ovn-techpreview

openshift-ci[bot] commented 4 months ago

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).

juzhao commented 4 months ago

also need to add cnv_abnormal to telemeter server metrics allow list: https://github.com/rhobs/configuration/blob/main/configuration/telemeter/metrics.json, otherwise can not find the metrics from telemeter server. steps see Synchronize the Telemeter server’s configuration part of https://rhobs-handbook.netlify.app/products/openshiftmonitoring/telemetry.md/

avlitman commented 4 months ago

@simonpasquier @jan--f Hi, will appreciate if we can approve this cherry-pick (:

avlitman commented 4 months ago

also need to add cnv_abnormal to telemeter server metrics allow list: https://github.com/rhobs/configuration/blob/main/configuration/telemeter/metrics.json, otherwise can not find the metrics from telemeter server. steps see Synchronize the Telemeter server’s configuration part of https://rhobs-handbook.netlify.app/products/openshiftmonitoring/telemetry.md/

@juzhao Do I also need 2 pr's one for 4.16 and one 4.17? thanks

simonpasquier commented 4 months ago

/label backport-risk-assessed

simonpasquier commented 4 months ago

/approve /lgtm

openshift-ci[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-monitoring-operator/blob/release-4.16/OWNERS)~~ [simonpasquier] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

simonpasquier commented 4 months ago

the change to openshift/telemeter doesn't need a backport. But for this PR, you'll need to create a OCPBUGS ticket.

rexagod commented 4 months ago

/label cherry-pick-approved

openshift-ci[bot] commented 4 months ago

@rexagod: Can not set label cherry-pick-approved: Must be member in one of these teams: []

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2364#issuecomment-2144738474): >/label cherry-pick-approved Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

rexagod commented 4 months ago

Ah, that label is not for me to set, cc @juzhao :)

rexagod commented 4 months ago

/retitle [release-4.16] OCPBUGS-34789: Add cnv_abnormal

openshift-ci-robot commented 4 months ago

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-34789, which is invalid:

expected the bug to target the "4.16.0" version, but no target version was set
release note text must be set and not match the template OR release note type must be set to "Release Note Not Required"
expected Jira Issue OCPBUGS-34789 to depend on a bug targeting a version in 4.17.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2364): >This is an automated cherry-pick of #2291 > >/assign avlitman Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

rexagod commented 4 months ago

/jira refresh

openshift-ci-robot commented 4 months ago

@rexagod: This pull request references Jira Issue OCPBUGS-34789, which is invalid:

bug is open, matching expected state (open)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
bug has dependents
dependent bug MON-3763 is not in the required OCPBUGS project

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2364#issuecomment-2145015044): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

rexagod commented 4 months ago

dependent bug MON-3763 is not in the required OCPBUGS project

@avlitman You'll need to close https://issues.redhat.com/browse/MON-3763 and link the parent PR (https://github.com/openshift/cluster-monitoring-operator/pull/2291) to an OCPBUG ticket.

simonpasquier commented 4 months ago

/retitle [release-4.16] OCPBUGS-34806: send cnv_abnormal metric via telemetry

openshift-ci-robot commented 4 months ago

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-34806, which is invalid:

release note text must be set and not match the template OR release note type must be set to "Release Note Not Required"
expected dependent Jira Issue OCPBUGS-34805 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is ASSIGNED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2364): >This is an automated cherry-pick of #2291 > >/assign avlitman Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

simonpasquier commented 4 months ago

/jira refresh

openshift-ci-robot commented 4 months ago

@simonpasquier: This pull request references Jira Issue OCPBUGS-34806, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

* bug is open, matching expected state (open) * bug target version (4.16.0) matches configured target version for branch (4.16.0) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST) * release note text is set and does not match the template * dependent bug [Jira Issue OCPBUGS-34805](https://issues.redhat.com//browse/OCPBUGS-34805) is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED) * dependent [Jira Issue OCPBUGS-34805](https://issues.redhat.com//browse/OCPBUGS-34805) targets the "4.17.0" version, which is one of the valid target versions: 4.17.0 * bug has dependents

Requesting review from QA contact: /cc @juzhao

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2364#issuecomment-2145301934): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

simonpasquier commented 4 months ago

/cherry-pick release-4.15

openshift-cherrypick-robot commented 4 months ago

@simonpasquier: once the present PR merges, I will cherry-pick it on top of release-4.15 in a new PR and assign it to you.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2364#issuecomment-2145306305): >/cherry-pick release-4.15 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

juzhao commented 4 months ago

/label cherry-pick-approved

openshift-ci-robot commented 4 months ago

@openshift-cherrypick-robot: Jira Issue OCPBUGS-34806: All pull requests linked via external trackers have merged:

openshift/cluster-monitoring-operator#2364

Jira Issue OCPBUGS-34806 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2364): >This is an automated cherry-pick of #2291 > >/assign avlitman Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

openshift-cherrypick-robot commented 4 months ago

@simonpasquier: #2364 failed to apply on top of branch "release-4.15":

Applying: Add cnv_abnormal
Using index info to reconstruct a base tree...
M   Documentation/data-collection.md
M   Documentation/sample-metrics.md
M   Documentation/telemetry/telemeter_query
M   manifests/0000_50_cluster-monitoring-operator_04-config.yaml
Falling back to patching base and 3-way merge...
Auto-merging manifests/0000_50_cluster-monitoring-operator_04-config.yaml
Auto-merging Documentation/telemetry/telemeter_query
CONFLICT (content): Merge conflict in Documentation/telemetry/telemeter_query
Auto-merging Documentation/sample-metrics.md
CONFLICT (content): Merge conflict in Documentation/sample-metrics.md
Auto-merging Documentation/data-collection.md
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Add cnv_abnormal
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2364#issuecomment-2145306305): >/cherry-pick release-4.15 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

openshift-bot commented 4 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-monitoring-operator-container-v4.16.0-202406040806.p0.ge008398.assembly.stream.el9 for distgit cluster-monitoring-operator. All builds following this will include this PR.

avlitman commented 4 months ago

dependent bug MON-3763 is not in the required OCPBUGS project

@avlitman You'll need to close https://issues.redhat.com/browse/MON-3763 and link the parent PR (#2291) to an OCPBUG ticket.

Done

openshift / cluster-monitoring-operator

[release-4.16] OCPBUGS-34806: send cnv_abnormal metric via telemetry #2364