openshift / cluster-monitoring-operator

Manage the OpenShift monitoring stack
Apache License 2.0
247 stars 363 forks source link

MON-3884: Send metric acm_managed_cluster_worker_cores via Telemetry #2367

Closed elgnay closed 4 months ago

elgnay commented 5 months ago

The related issue: https://issues.redhat.com/browse/MON-3884

openshift-ci-robot commented 5 months ago

@elgnay: This pull request references MON-3884 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2367): >The related issue: https://issues.redhat.com/browse/MON-3884 > > >* [ ] I added CHANGELOG entry for this change. >* [x] No user facing changes, so no entry in CHANGELOG was needed. > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
elgnay commented 5 months ago

/test e2e-aws-ovn-single-node /test e2e-agnostic-operator

elgnay commented 4 months ago

/test e2e-aws-ovn-single-node

elgnay commented 4 months ago

/hold

elgnay commented 4 months ago

/hold cancel

elgnay commented 4 months ago

/test versions

openshift-ci-robot commented 4 months ago

@elgnay: This pull request references MON-3884 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2367): >The related issue: https://issues.redhat.com/browse/MON-3884 > > >* [ ] I added CHANGELOG entry for this change. >* [x] No user facing changes, so no entry in CHANGELOG was needed. > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
elgnay commented 4 months ago

/retest

juzhao commented 4 months ago

ci/prow/versions job failed for thanos version https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_cluster-monitoring-operator/2367/pull-ci-openshift-cluster-monitoring-operator-master-versions/1796013340560986112

 --- a/jsonnet/versions.yaml
+++ b/jsonnet/versions.yaml
@@ -25,4 +25,4 @@ versions:
     prometheus: 2.52.0
     prometheusAdapter: 0.11.2
     prometheusOperator: 0.73.2
-    thanos: 0.35.0
+    thanos: 0.35.1
make: *** [Makefile:177: check-versions] Error 1
{"component":"entrypoint","error":"wrapped process failed: exit status 2","file":"sigs.k8s.io/prow/pkg/entrypoint/run.go:84","func":"sigs.k8s.io/prow/pkg/entrypoint.Options.internalRun","level":"error","msg":"Error executing test process","severity":"error","time":"2024-05-30T03:03:17Z"} 

@machine424 @marioferh , since ci/prow/versions job is not a required job, I think we could ignore the failure, or do you think we'd better fix it?

juzhao commented 4 months ago

/label qe-approved

openshift-ci-robot commented 4 months ago

@elgnay: This pull request references MON-3884 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2367): >The related issue: https://issues.redhat.com/browse/MON-3884 > > >* [ ] I added CHANGELOG entry for this change. >* [x] No user facing changes, so no entry in CHANGELOG was needed. > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 4 months ago

@elgnay: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
simonpasquier commented 4 months ago

@juzhao

since ci/prow/versions job is not a required job, I think we could ignore the failure, or do you think we'd better fix it?

Correct, we don't need to worry about it. It is only there to remind us that we need to merge PRs like https://github.com/openshift/cluster-monitoring-operator/pull/2376.

simonpasquier commented 4 months ago

/approve /lgtm

openshift-ci[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elgnay, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-monitoring-operator/blob/master/OWNERS)~~ [simonpasquier] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-bot commented 4 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-monitoring-operator-container-v4.17.0-202406041111.p0.ga83f250.assembly.stream.el9 for distgit cluster-monitoring-operator. All builds following this will include this PR.