openshift / cluster-monitoring-operator

Manage the OpenShift monitoring stack
Apache License 2.0
247 stars 360 forks source link

MON-2065: jsonnet: exclude `kubernetes-storage` rules #2377

Closed jan--f closed 1 month ago

jan--f commented 3 months ago

These alert rules are now hosted in the cluster-storage-operator. See https://github.com/openshift/cluster-storage-operator/pull/477.

openshift-ci-robot commented 3 months ago

@jan--f: This pull request references MON-2065 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2377): >These alert rules are now hosted in the cluster-storage-operator. See https://github.com/openshift/cluster-storage-operator/pull/477. > > > >* [ ] I added CHANGELOG entry for this change. >* [ ] No user facing changes, so no entry in CHANGELOG was needed. > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
jan--f commented 2 months ago

/retest /jira refresh

openshift-ci-robot commented 2 months ago

@jan--f: This pull request references MON-2065 which is a valid jira issue.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2377#issuecomment-2173135811): >/retest >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
duanwei33 commented 2 months ago

Storage QE tested https://github.com/openshift/cluster-storage-operator/pull/477, see https://github.com/openshift/cluster-storage-operator/pull/477#issuecomment-2219620402. Just FYI

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jan--f, marioferh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-monitoring-operator/blob/master/OWNERS)~~ [jan--f,marioferh] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 2 months ago

/retest-required

Remaining retests: 0 against base HEAD 5341b80d4868fb1a330b14c8beff4c3ebba01b69 and 2 for PR HEAD 55325c59a024a9c36e036d5a3f24473d670ae494 in total

jan--f commented 2 months ago

/retest

openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD c40256c7a56cb38c399a27bb81475e0536d2ee23 and 1 for PR HEAD 55325c59a024a9c36e036d5a3f24473d670ae494 in total

openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD c40256c7a56cb38c399a27bb81475e0536d2ee23 and 2 for PR HEAD 55325c59a024a9c36e036d5a3f24473d670ae494 in total

openshift-ci[bot] commented 1 month ago

@jan--f: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-bot commented 1 month ago

[ART PR BUILD NOTIFIER]

Distgit: cluster-monitoring-operator This PR has been included in build cluster-monitoring-operator-container-v4.17.0-202407230118.p0.g82b6cc1.assembly.stream.el9. All builds following this will include this PR.