search

openshift / cluster-monitoring-operator

Manage the OpenShift monitoring stack
Apache License 2.0
247 stars 360 forks source link

[release-4.16] OCPBUGS-35061,MON-3795:Backport anp telemetry #2379

Closed tssurya closed 2 months ago

tssurya commented 3 months ago

Backport of https://github.com/openshift/cluster-monitoring-operator/pull/2297

@simonpasquier : since this is only for telemetry collection do you think its user facing and needs changelog?

openshift-ci-robot commented 3 months ago

@tssurya: This pull request references Jira Issue OCPBUGS-35061, which is valid.

7 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.16.0) matches configured target version for branch (4.16.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST) * release note type set to "Release Note Not Required" * dependent bug [Jira Issue OCPBUGS-29619](https://issues.redhat.com//browse/OCPBUGS-29619) is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED) * dependent [Jira Issue OCPBUGS-29619](https://issues.redhat.com//browse/OCPBUGS-29619) targets the "4.17.0" version, which is one of the valid target versions: 4.17.0 * bug has dependents

The bug has been updated to refer to the pull request using the external bug tracker.

This pull request references MON-3795 which is a valid jira issue.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2379): >Backport of https://github.com/openshift/cluster-monitoring-operator/pull/2297 > >* [ ] I added CHANGELOG entry for this change. >* [ ] No user facing changes, so no entry in CHANGELOG was needed. > >@simonpasquier : since this is only for telemetry collection do you think its user facing and needs changelog? > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
simonpasquier commented 2 months ago

/lgtm /label backport-risk-assessed /approve

asood-rh commented 2 months ago

/label cherry-pick-approved

openshift-ci[bot] commented 2 months ago

@asood-rh: Can not set label cherry-pick-approved: Must be member in one of these teams: []

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2379#issuecomment-2160589235): >/label cherry-pick-approved Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
tssurya commented 2 months ago

/label cherry-pick-approved

openshift-ci[bot] commented 2 months ago

@tssurya: Can not set label cherry-pick-approved: Must be member in one of these teams: []

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2379#issuecomment-2160593852): >/label cherry-pick-approved Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
simonpasquier commented 2 months ago

/label backport-risk-assessed /approve

simonpasquier commented 2 months ago

/hold

juzhao commented 2 months ago

@tssurya please see my comments and fix the issue

tssurya commented 2 months ago

ack I am trying to execute make docs to regenerate docs:

go: finding module for package go.opencensus.io/trace/propagation
go: finding module for package go.opencensus.io/plugin/ochttp
go: finding module for package go.opencensus.io/trace
/home/surya/go/pkg/mod/google.golang.org/api@v0.114.0/transport/http/dial.go:18:2: module go.opencensus.io@latest found (v0.24.0), but does not contain package go.opencensus.io/plugin/ochttp
/home/surya/go/pkg/mod/google.golang.org/api@v0.114.0/transport/http/internal/propagation/http.go:20:2: module go.opencensus.io@latest found (v0.24.0), but does not contain package go.opencensus.io/trace
/home/surya/go/pkg/mod/google.golang.org/api@v0.114.0/transport/http/internal/propagation/http.go:21:2: module go.opencensus.io@latest found (v0.24.0), but does not contain package go.opencensus.io/trace/propagation
make: *** [Makefile:272: /home/surya/go/src/github.com/openshift/cluster-monitoring-operator/tmp/bin/docgen] Error 123

running into issues with go modules let me fix that and repush

tssurya commented 2 months ago

updated!

tssurya commented 2 months ago

@juzhao : PTAL!

juzhao commented 2 months ago

/label cherry-pick-approved /label qe-approved /lgtm

openshift-ci-robot commented 2 months ago

@tssurya: This pull request references Jira Issue OCPBUGS-35061, which is valid.

7 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.16.0) matches configured target version for branch (4.16.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST) * release note type set to "Release Note Not Required" * dependent bug [Jira Issue OCPBUGS-29619](https://issues.redhat.com//browse/OCPBUGS-29619) is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED) * dependent [Jira Issue OCPBUGS-29619](https://issues.redhat.com//browse/OCPBUGS-29619) targets the "4.17.0" version, which is one of the valid target versions: 4.17.0 * bug has dependents

The bug has been updated to refer to the pull request using the external bug tracker.

This pull request references MON-3795 which is a valid jira issue.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2379): >Backport of https://github.com/openshift/cluster-monitoring-operator/pull/2297 > >* [ ] I added CHANGELOG entry for this change. >* [ ] No user facing changes, so no entry in CHANGELOG was needed. > >@simonpasquier : since this is only for telemetry collection do you think its user facing and needs changelog? > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juzhao, simonpasquier, tssurya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-monitoring-operator/blob/release-4.16/OWNERS)~~ [simonpasquier] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
juzhao commented 2 months ago

/test e2e-agnostic-operator

openshift-ci[bot] commented 2 months ago

@tssurya: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
juzhao commented 2 months ago

/hold cancel

openshift-ci-robot commented 2 months ago

@tssurya: Jira Issue OCPBUGS-35061: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-35061 has not been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2379): >Backport of https://github.com/openshift/cluster-monitoring-operator/pull/2297 > >* [ ] I added CHANGELOG entry for this change. >* [ ] No user facing changes, so no entry in CHANGELOG was needed. > >@simonpasquier : since this is only for telemetry collection do you think its user facing and needs changelog? > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 2 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-monitoring-operator-container-v4.16.0-202406170957.p0.gb1fb108.assembly.stream.el9 for distgit cluster-monitoring-operator. All builds following this will include this PR.

openshift-merge-robot commented 2 months ago

Fix included in accepted release 4.16.0-0.nightly-2024-07-04-084325