search

openshift / cluster-monitoring-operator

Manage the OpenShift monitoring stack
Apache License 2.0
247 stars 360 forks source link

MON-3894: revert(monitoring-plugin): undo nginx caching tweaks as the issue was… #2380

Closed machine424 closed 2 months ago

machine424 commented 2 months ago

… resolved at its root cause.

Revert "prevent plugin entry assets from caching"

This reverts commit c6652ade52bd56bb5f4c4af10cfd28b6b350eccd.

Revert "Move config to jsonnet code and regenerate"

This reverts commit eb6a40c4ea30304c03eb4709d7e82ece7b98bd1a.

machine424 commented 2 months ago

/cc @simonpasquier

openshift-ci-robot commented 2 months ago

@machine424: This pull request references MON-3894 which is a valid jira issue.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2380): >… resolved at its root cause. > >Revert "prevent plugin entry assets from caching" > >This reverts commit c6652ade52bd56bb5f4c4af10cfd28b6b350eccd. > >Revert "Move config to jsonnet code and regenerate" > >This reverts commit eb6a40c4ea30304c03eb4709d7e82ece7b98bd1a. > > > >* [ ] I added CHANGELOG entry for this change. >* [ ] No user facing changes, so no entry in CHANGELOG was needed. > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
simonpasquier commented 2 months ago

/lgtm /hold

I guess that we don't have other ways to verify the non-regression than checking manually?

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: machine424, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-monitoring-operator/blob/master/OWNERS)~~ [machine424,simonpasquier] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
machine424 commented 2 months ago

/retest

machine424 commented 2 months ago

I guess that we don't have other ways to verify the non-regression than checking manually?

I'm afraid we don't have any tests for this, I wanted to make the change at the beginning of 4.17 dev and wait for feedback.

I'll see with the console folks for the tests, there are others we can add as well.

machine424 commented 2 months ago

/hold cancel

openshift-bot commented 2 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-monitoring-operator-container-v4.17.0-202406132111.p0.g701e6d3.assembly.stream.el9 for distgit cluster-monitoring-operator. All builds following this will include this PR.