search

openshift / cluster-monitoring-operator

Manage the OpenShift monitoring stack
Apache License 2.0
247 stars 360 forks source link

MON-3800: jsonnet: update prometheus dep to fetch the PrometheusKuber… #2392

Closed machine424 closed 2 months ago

machine424 commented 2 months ago

…netesListWatchFailures alert added upstream in

https://github.com/prometheus/prometheus/pull/14308

The metric was added in prometheus v2.52.0, thus available in the current downstream version.

Also this:

jsonnet: Pin https://github.com/kubernetes-monitoring/kubernetes-mixin.git dep version

as newer versions are breaking.

This is a temporary solution to avoid blocking the other deps updates

See https://issues.redhat.com/browse/MON-3837

openshift-ci-robot commented 2 months ago

@machine424: This pull request references MON-3800 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2392): >…netesListWatchFailures alert added upstream in > >https://github.com/prometheus/prometheus/pull/14308 > >The metric was added in prometheus v2.52.0, thus available in the current downstream version. > > > >* [ ] I added CHANGELOG entry for this change. >* [ ] No user facing changes, so no entry in CHANGELOG was needed. > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
juzhao commented 2 months ago

/retest

juzhao commented 2 months ago

/label qe-approved

openshift-ci-robot commented 2 months ago

@machine424: This pull request references MON-3800 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2392): >…netesListWatchFailures alert added upstream in > >https://github.com/prometheus/prometheus/pull/14308 > >The metric was added in prometheus v2.52.0, thus available in the current downstream version. > > > >* [ ] I added CHANGELOG entry for this change. >* [ ] No user facing changes, so no entry in CHANGELOG was needed. > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 2 months ago

@machine424: This pull request references MON-3800 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2392): >…netesListWatchFailures alert added upstream in > >https://github.com/prometheus/prometheus/pull/14308 > >The metric was added in prometheus v2.52.0, thus available in the current downstream version. > >--- > >Also this: > >jsonnet: Pin https://github.com/kubernetes-monitoring/kubernetes-mixin.git dep version > >as newer versions are breaking. > >This is a temporary solution to avoid blocking the other deps updates > >See https://issues.redhat.com/browse/MON-3837 > > > >* [ ] I added CHANGELOG entry for this change. >* [ ] No user facing changes, so no entry in CHANGELOG was needed. > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: machine424, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-monitoring-operator/blob/master/OWNERS)~~ [machine424,simonpasquier] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
simonpasquier commented 2 months ago

/skip

openshift-ci[bot] commented 2 months ago

@machine424: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/versions 2399dc842eca7e04a411e0e6032749a1211d3cb4 link false /test versions

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-bot commented 2 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-monitoring-operator-container-v4.17.0-202406261807.p0.gde82431.assembly.stream.el9 for distgit cluster-monitoring-operator. All builds following this will include this PR.