search

openshift / cluster-monitoring-operator

Manage the OpenShift monitoring stack
Apache License 2.0
247 stars 360 forks source link

OCPBUGS-36299: Revert #2392 "MON-3800: jsonnet: update prometheus dep to fetch the PrometheusKuber…" #2398

Closed neisw closed 2 months ago

neisw commented 2 months ago

Reverts #2392 ; tracked by https://issues.redhat.com/browse/OCPBUGS-36299

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

Hypershift failures due to PrometheusKubernetesListWatchFailures

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem:

/payload-aggregate periodic-ci-openshift-hypershift-release-4.17-periodics-e2e-aws-ovn-conformance 10

CC: @machine424

PR created by Revertomatic:tm:
openshift-ci-robot commented 2 months ago

@neisw: This pull request references MON-3800 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2398): > >Reverts #2392 ; tracked by https://issues.redhat.com/browse/OCPBUGS-36299 > >Per [OpenShift policy](https://github.com/openshift/enhancements/blob/master/enhancements/release/improving-ci-signal.md#quick-revert), we are reverting this breaking change to get CI and/or nightly payloads flowing again. > >Hypershift failures due to PrometheusKubernetesListWatchFailures > >To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem: > >``` >/payload-aggregate periodic-ci-openshift-hypershift-release-4.17-periodics-e2e-aws-ovn-conformance 10 >``` > >CC: @machine424 > >
>PR created by Revertomatic:tm: >
> Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
neisw commented 2 months ago

/payload-aggregate periodic-ci-openshift-hypershift-release-4.17-periodics-e2e-aws-ovn-conformance 10

openshift-ci[bot] commented 2 months ago

@neisw: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/2d1abf90-34d9-11ef-9bff-91cb094a0589-0

neisw commented 2 months ago

/override ci/prow/e2e-aws-ovn-techpreview

All techpreview jobs are failing due to another issue currently

openshift-ci[bot] commented 2 months ago

@neisw: Overrode contexts on behalf of neisw: ci/prow/e2e-aws-ovn-techpreview

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2398#issuecomment-2195939037): >/override ci/prow/e2e-aws-ovn-techpreview > >All techpreview jobs are failing due to another issue currently Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
neisw commented 2 months ago

/retest-required

neisw commented 2 months ago

payload validation for periodic-ci-openshift-hypershift-release-4.17-periodics-e2e-aws-ovn-conformance passed

openshift-ci[bot] commented 2 months ago

@neisw: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/versions e1fc00bd763d1c7e6d27b5b008eb3b322f06f057 link false /test versions

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
jan--f commented 2 months ago

/retitle OCPBUGS-36299: Revert #2392 "MON-3800: jsonnet: update prometheus dep to fetch the PrometheusKuber…"

openshift-ci-robot commented 2 months ago

@neisw: This pull request references Jira Issue OCPBUGS-36299, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2398): > >Reverts #2392 ; tracked by https://issues.redhat.com/browse/OCPBUGS-36299 > >Per [OpenShift policy](https://github.com/openshift/enhancements/blob/master/enhancements/release/improving-ci-signal.md#quick-revert), we are reverting this breaking change to get CI and/or nightly payloads flowing again. > >Hypershift failures due to PrometheusKubernetesListWatchFailures > >To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem: > >``` >/payload-aggregate periodic-ci-openshift-hypershift-release-4.17-periodics-e2e-aws-ovn-conformance 10 >``` > >CC: @machine424 > >
>PR created by Revertomatic:tm: >
> Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
machine424 commented 2 months ago

I'd be great to only revert the first commit from that PR https://github.com/openshift/cluster-monitoring-operator/commit/7ab749466be0e6930cdc08d1a2a276623f0bcc5d The second one is unrelated and is still needed. But I can always add it back after the revert if it'll make it easy for you. /lgtm /hold (see my comment on jira regarding the hold)

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: machine424, neisw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-monitoring-operator/blob/master/OWNERS)~~ [machine424] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
machine424 commented 2 months ago

/hold cancel

neisw commented 2 months ago

/label docs-approved /label px-approved /label qe-approved

neisw commented 2 months ago

/jira refresh

openshift-ci-robot commented 2 months ago

@neisw: This pull request references Jira Issue OCPBUGS-36299, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.17.0) matches configured target version for branch (4.17.0) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @juzhao

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2398#issuecomment-2196728868): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
machine424 commented 2 months ago

/skip

openshift-ci-robot commented 2 months ago

@neisw: Jira Issue OCPBUGS-36299: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-36299 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2398): > >Reverts #2392 ; tracked by https://issues.redhat.com/browse/OCPBUGS-36299 > >Per [OpenShift policy](https://github.com/openshift/enhancements/blob/master/enhancements/release/improving-ci-signal.md#quick-revert), we are reverting this breaking change to get CI and/or nightly payloads flowing again. > >Hypershift failures due to PrometheusKubernetesListWatchFailures > >To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem: > >``` >/payload-aggregate periodic-ci-openshift-hypershift-release-4.17-periodics-e2e-aws-ovn-conformance 10 >``` > >CC: @machine424 > >
>PR created by Revertomatic:tm: >
> Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 2 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-monitoring-operator-container-v4.17.0-202406281639.p0.gcd0d275.assembly.stream.el9 for distgit cluster-monitoring-operator. All builds following this will include this PR.