search

openshift / cluster-monitoring-operator

Manage the OpenShift monitoring stack
Apache License 2.0
247 stars 360 forks source link

MON-3921: Revert "Revert "Merge pull request #2392 from machine424/f-… #2403

Closed machine424 closed 1 month ago

machine424 commented 2 months ago

…alert""

This reverts commit e1fc00bd763d1c7e6d27b5b008eb3b322f06f057.

To re-introduce changes in https://github.com/openshift/cluster-monitoring-operator/pull/2392

This will be merged once the new e2e-hypershift-conformance test is green.

openshift-ci-robot commented 2 months ago

@machine424: This pull request references MON-3921 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2403): >…alert"" > >This reverts commit e1fc00bd763d1c7e6d27b5b008eb3b322f06f057. > >To re-introduce changes in https://github.com/openshift/cluster-monitoring-operator/pull/2392 > >This will be merged once the new e2e-hypershift-conformance test is green. > > > >* [ ] I added CHANGELOG entry for this change. >* [ ] No user facing changes, so no entry in CHANGELOG was needed. > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
machine424 commented 2 months ago

/retest

machine424 commented 2 months ago

/retest

Tai-RedHat commented 2 months ago

pr tested with cluster-bot

machine424 commented 2 months ago

/payload-job-with-prs periodic-ci-openshift-hypershift-release-4.17-periodics-e2e-aws-ovn-conformance https://github.com/openshift/hypershift/pull/4348

openshift-ci[bot] commented 2 months ago

@machine424: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info.

machine424 commented 2 months ago

/payload-job-with-prs periodic-ci-openshift-hypershift-release-4.17-periodics-e2e-aws-ovn-conformance openshift/hypershift#4348

openshift-ci[bot] commented 2 months ago

@machine424: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/75d1c460-3ee1-11ef-8661-0cf1caa5fc92-0

machine424 commented 2 months ago

/payload-job-with-prs periodic-ci-openshift-hypershift-release-4.17-periodics-e2e-aws-ovn-conformance openshift/hypershift#4348

openshift-ci[bot] commented 2 months ago

@machine424: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/598fd4d0-3ef6-11ef-96f4-013c02769497-0

machine424 commented 2 months ago

/retest

machine424 commented 1 month ago

/payload-job-with-prs periodic-ci-openshift-hypershift-release-4.17-periodics-e2e-aws-ovn-conformance openshift/hypershift#4348

openshift-ci[bot] commented 1 month ago

@machine424: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/53aafae0-4d88-11ef-8cf8-0a6efb8fedbc-0

machine424 commented 1 month ago

/retest

machine424 commented 1 month ago

@machine424: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

* periodic-ci-openshift-hypershift-release-4.17-periodics-e2e-aws-ovn-conformance

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/53aafae0-4d88-11ef-8cf8-0a6efb8fedbc-0

With the hypershift fix, shouldn't report any alerts in firing state apart from Watchdog and AlertmanagerReceiversNotConfigured check in hypershift tests is no longer failing. (+ there are no RBAC issues logs on Prometheus')

strangely ci/prow/e2e-hypershift-conformance is also passing without the hypershift fix, the reason is that shouldn't report any alerts in firing state apart from Watchdog and AlertmanagerReceiversNotConfigured may be checked before the alert is firing (I was expecting the check to run at the end)

machine424 commented 1 month ago

/hold until https://github.com/openshift/hypershift/pull/4348 is merged.

machine424 commented 1 month ago

/retest

machine424 commented 1 month ago

/hold cancel https://github.com/openshift/hypershift/pull/4348 was merged.

jan--f commented 1 month ago

/retest /lgtm

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jan--f, machine424

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-monitoring-operator/blob/master/OWNERS)~~ [jan--f,machine424] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD f15addc8c1bd77851d395c662d452a365fb05370 and 2 for PR HEAD 8a657761a5c27aa2e916e85411314ba4d5042029 in total

openshift-ci[bot] commented 1 month ago

@machine424: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/versions 8a657761a5c27aa2e916e85411314ba4d5042029 link false /test versions

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD 32d35585049d9baa08ebd8bd7822a1d2497f3876 and 1 for PR HEAD 8a657761a5c27aa2e916e85411314ba4d5042029 in total

machine424 commented 1 month ago

/skip