Closed simonpasquier closed 1 month ago
/jira cherrypick OCPBUGS-36482
@simonpasquier: Jira Issue OCPBUGS-36482 has been cloned as Jira Issue OCPBUGS-36563. Will retitle bug to link to clone. /retitle OCPBUGS-36563: OCPBUGS-xxx: add runbook_url annotations
@simonpasquier: This pull request references Jira Issue OCPBUGS-36563, which is invalid:
Comment /jira refresh
to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.
The bug has been updated to refer to the pull request using the external bug tracker.
backport-risk-assessed
/assign @jan--f
/label backport-risk-assessed /lgtm
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jan--f, simonpasquier
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/jira refresh
@juzhao: This pull request references Jira Issue OCPBUGS-36563, which is valid. The bug has been moved to the POST state.
Requesting review from QA contact: /cc @juzhao
The bug has been updated to refer to the pull request using the external bug tracker.
compared with 4.16 PR: https://github.com/openshift/cluster-monitoring-operator/pull/2404 4.15 PR missed runbook_url annotations for TargetDown/PrometheusDuplicateTimestamps/KubeAggregatedAPIErrors alerts, these alerts exist in 4.15
# oc get clusterversion
NAME VERSION AVAILABLE PROGRESSING SINCE STATUS
version 4.15.0-0.nightly-2024-07-04-091603 True False 6h54m Cluster version is 4.15.0-0.nightly-2024-07-04-091603
# oc -n openshift-monitoring get prometheusrules cluster-monitoring-operator-prometheus-rules -o jsonpath='{.spec.groups[*].rules[?(@.alert=="TargetDown")]}' | jq '{alert: .alert, runbook_url: .annotations.runbook_url}'
{
"alert": "TargetDown",
"runbook_url": null
}
# oc -n openshift-monitoring get prometheusrules prometheus-k8s-prometheus-rules -o jsonpath='{.spec.groups[*].rules[?(@.alert=="PrometheusDuplicateTimestamps")]}' | jq '{alert: .alert, runbook_url: .annotations.runbook_url}'
{
"alert": "PrometheusDuplicateTimestamps",
"runbook_url": null
}
# oc -n openshift-monitoring get prometheusrules kubernetes-monitoring-rules -o jsonpath='{.spec.groups[*].rules[?(@.alert=="KubeAggregatedAPIErrors")]}' | jq '{alert: .alert, runbook_url: .annotations.runbook_url}'
{
"alert": "KubeAggregatedAPIErrors",
"runbook_url": null
}
@juzhao the runbook links for TargetDown, PrometheusDuplicateTimestamps and KubeAggregatedAPIErrors were added during the 4.16 dev cycle but not backported. If they should then it's another OCPBUGS ticket IMHO.
/label cherry-pick-approved /label qe-approved
@simonpasquier: This pull request references Jira Issue OCPBUGS-36563, which is valid.
Requesting review from QA contact: /cc @juzhao
@simonpasquier: all tests passed!
Full PR test history. Your PR dashboard.
@simonpasquier: Jira Issue OCPBUGS-36563: All pull requests linked via external trackers have merged:
Jira Issue OCPBUGS-36563 has been moved to the MODIFIED state.
[ART PR BUILD NOTIFIER]
Distgit: cluster-monitoring-operator This PR has been included in build cluster-monitoring-operator-container-v4.15.0-202407291038.p0.g2fa441a.assembly.stream.el9. All builds following this will include this PR.
Fix included in accepted release 4.15.0-0.nightly-2024-07-29-185318