openshift / cluster-monitoring-operator

Manage the OpenShift monitoring stack
Apache License 2.0
247 stars 360 forks source link

MON-3900: Remove prometheus-adapter code #2409

Closed slashpai closed 1 month ago

slashpai commented 2 months ago

pkg: remove prometheus-adapter code

openshift-ci-robot commented 2 months ago

@slashpai: This pull request references MON-3900 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2409): >pkg: remove prometheus-adapter code > > > >* [x] I added CHANGELOG entry for this change. >* [ ] No user facing changes, so no entry in CHANGELOG was needed. > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
slashpai commented 1 month ago

/skip

slashpai commented 1 month ago

cc @simonpasquier @jan--f @machine424

slashpai commented 1 month ago

/retest-required

slashpai commented 1 month ago

@simonpasquier could you please review again?

jan--f commented 1 month ago

Looks good! Happy to merge when CI and Simon are happy :)

slashpai commented 1 month ago

I will rebase once https://github.com/openshift/cluster-monitoring-operator/pull/2414 is merged to fix generate issue

openshift-ci[bot] commented 1 month ago

@slashpai: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
jan--f commented 1 month ago

/lgtm

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jan--f, slashpai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-monitoring-operator/blob/master/OWNERS)~~ [jan--f,slashpai] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-bot commented 1 month ago

[ART PR BUILD NOTIFIER]

Distgit: cluster-monitoring-operator This PR has been included in build cluster-monitoring-operator-container-v4.17.0-202407291514.p0.gf15addc.assembly.stream.el9. All builds following this will include this PR.