openshift / cluster-monitoring-operator

Manage the OpenShift monitoring stack
Apache License 2.0
247 stars 363 forks source link

MON-3895: Add tempo operator metrics #2421

Closed rubenvp8510 closed 1 month ago

rubenvp8510 commented 2 months ago
simonpasquier commented 2 months ago

/retitle MON-3895: Add tempo operator metrics

openshift-ci-robot commented 2 months ago

@rubenvp8510: This pull request references MON-3895 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2421): > > >* [ ] I added CHANGELOG entry for this change. >* [x] No user facing changes, so no entry in CHANGELOG was needed. > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
rubenvp8510 commented 2 months ago

Hello @simonpasquier I renamed this to match the recording rules

Those are the rules defined in the tempo bundle:

apiVersion: monitoring.coreos.com/v1
kind: PrometheusRule
metadata:
  labels:
    app.kubernetes.io/managed-by: operator-lifecycle-manager
    app.kubernetes.io/name: tempo-operator
    app.kubernetes.io/part-of: tempo-operator
  name: tempo-operator-tempo-operator-prometheus-rules
spec:
  groups:
  - name: tempo-operator-monitoring.rules
    rules:
    - expr: sum by (type) (tempo_operator_tempostack_storage_backend)
      record: type:tempo_operator_tempostack_storage_backend:sum
    - expr: sum by (state) (tempo_operator_tempostack_managed)
      record: state:tempo_operator_tempostack_managed:sum
    - expr: sum by (type) (tempo_operator_tempostack_multi_tenancy)
      record: enabled:tempo_operator_tempostack_multi_tenancy:sum
    - expr: sum by (enabled) (tempo_operator_tempostack_jaeger_ui)
      record: enabled:tempo_operator_tempostack_jaeger_ui:sum

Let me know if this is enough for proceed and merge this PR. Thank you very much for taking care of this!

rubenvp8510 commented 1 month ago

/retest-required

rubenvp8510 commented 1 month ago

/retest

rubenvp8510 commented 1 month ago

/retest

rubenvp8510 commented 1 month ago

@simonpasquier I think this is ready

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rubenvp8510, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-monitoring-operator/blob/master/OWNERS)~~ [simonpasquier] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD 0cffd8a3c81c0f7271912b20e086ab7de5e2eba9 and 2 for PR HEAD 4cdc66710c12b2492566c5546d38765d7ce3590e in total

openshift-ci[bot] commented 1 month ago

@rubenvp8510: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-bot commented 1 month ago

[ART PR BUILD NOTIFIER]

Distgit: cluster-monitoring-operator This PR has been included in build cluster-monitoring-operator-container-v4.18.0-202408272341.p0.gf7e92e8.assembly.stream.el9. All builds following this will include this PR.