openshift / cluster-monitoring-operator

Manage the OpenShift monitoring stack
Apache License 2.0
247 stars 360 forks source link

OCPBUGS-35095: drop redundant KSM selector from `KubeCPUOvercommit` #2422

Open rexagod opened 1 month ago

rexagod commented 1 month ago

Sync changes with upstream.

openshift-ci-robot commented 1 month ago

@rexagod: This pull request references Jira Issue OCPBUGS-35095, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2422): >Sync changes with upstream. > > > >* [ ] I added CHANGELOG entry for this change. >* [x] No user facing changes, so no entry in CHANGELOG was needed. > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rexagod

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-monitoring-operator/blob/master/OWNERS)~~ [rexagod] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
rexagod commented 1 month ago

/jira refresh

openshift-ci-robot commented 1 month ago

@rexagod: This pull request references Jira Issue OCPBUGS-35095, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.17.0) matches configured target version for branch (4.17.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @juzhao

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2422#issuecomment-2256781262): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
juzhao commented 1 month ago

/retest

simonpasquier commented 1 month ago

@rexagod need to run "make generate"?

openshift-ci[bot] commented 1 month ago

@rexagod: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/verify a748a25df278abfdd931b0d559bd5e401472c79a link true /test verify
ci/prow/rules a748a25df278abfdd931b0d559bd5e401472c79a link true /test rules
ci/prow/e2e-aws-ovn-techpreview a748a25df278abfdd931b0d559bd5e401472c79a link true /test e2e-aws-ovn-techpreview
ci/prow/versions a748a25df278abfdd931b0d559bd5e401472c79a link false /test versions
ci/prow/e2e-agnostic-operator a748a25df278abfdd931b0d559bd5e401472c79a link true /test e2e-agnostic-operator
ci/prow/generate a748a25df278abfdd931b0d559bd5e401472c79a link true /test generate

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
simonpasquier commented 1 month ago

/hold

rexagod commented 1 month ago

IIUC It seems updating k-mixin dependency to the corresponding upstream commit breaks the dashboards. Earlier I used to jb update <dependency>@<commit> and generate the manifests (so as to not update all the deps, including the breaking dashboard updates), but I was afraid that we'll hit a point where it won't be possible anymore due to the recent refactor upstream.

https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_cluster-monitoring-operator/2422/pull-ci-openshift-cluster-monitoring-operator-master-generate/1818209242499256320#1:build-log.txt%3A275

rexagod commented 1 month ago

I can push for a branch upstream that ports post-refactor commits while making use of the earlier Grafana v11 dashboards. Or we might want to refactor our jsonnets internally (better IMO).

openshift-merge-robot commented 1 month ago

PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.