Open rexagod opened 1 month ago
@rexagod: This pull request references Jira Issue OCPBUGS-35095, which is invalid:
Comment /jira refresh
to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.
The bug has been updated to refer to the pull request using the external bug tracker.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: rexagod
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/jira refresh
@rexagod: This pull request references Jira Issue OCPBUGS-35095, which is valid.
Requesting review from QA contact: /cc @juzhao
/retest
@rexagod need to run "make generate"?
@rexagod: The following tests failed, say /retest
to rerun all failed tests or /retest-required
to rerun all mandatory failed tests:
Test name | Commit | Details | Required | Rerun command |
---|---|---|---|---|
ci/prow/verify | a748a25df278abfdd931b0d559bd5e401472c79a | link | true | /test verify |
ci/prow/rules | a748a25df278abfdd931b0d559bd5e401472c79a | link | true | /test rules |
ci/prow/e2e-aws-ovn-techpreview | a748a25df278abfdd931b0d559bd5e401472c79a | link | true | /test e2e-aws-ovn-techpreview |
ci/prow/versions | a748a25df278abfdd931b0d559bd5e401472c79a | link | false | /test versions |
ci/prow/e2e-agnostic-operator | a748a25df278abfdd931b0d559bd5e401472c79a | link | true | /test e2e-agnostic-operator |
ci/prow/generate | a748a25df278abfdd931b0d559bd5e401472c79a | link | true | /test generate |
Full PR test history. Your PR dashboard.
/hold
IIUC It seems updating k-mixin
dependency to the corresponding upstream commit breaks the dashboards. Earlier I used to jb update <dependency>@<commit>
and generate
the manifests (so as to not update all the deps, including the breaking dashboard updates), but I was afraid that we'll hit a point where it won't be possible anymore due to the recent refactor upstream.
I can push for a branch upstream that ports post-refactor commits while making use of the earlier Grafana v11 dashboards. Or we might want to refactor our jsonnets internally (better IMO).
PR needs rebase.
Sync changes with upstream.