Allow scrapping of OpenStack load-balancer-id

[mandre]

This PR is made of two separate changes.

The first one remove kube_*_annotations from the deny list, as it is no longer needed since https://github.com/kubernetes/kube-state-metrics/pull/2145 and prevents the collection of kube_*_annotations.

The second change effectively enables scrapping of OpenStack load-balancer-id.

• [x] I added CHANGELOG entry for this change.
• [ ] No user facing changes, so no entry in CHANGELOG was needed.

[openshift-ci[bot]]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mandre Once this PR has been reviewed and has the lgtm label, please assign machine424 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/cluster-monitoring-operator/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

[jan--f]

/cc @rexagod

[jan--f]

I'm generally in favor of this, though I think we have yet another setting to gatekeep that should really be user accessible, similar to https://issues.redhat.com/browse/MON-2809.

Iiuc we also no longer need to deny kube_secret_labels?

[mandre]

I'm generally in favor of this, though I think we have yet another setting to gatekeep that should really be user accessible, similar to https://issues.redhat.com/browse/MON-2809.

Iiuc we also no longer need to deny kube_secret_labels?

Yep, that's also my understanding I can do that in a separate PR if you'd like.

[openshift-ci[bot]]

@mandre: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-agnostic-operator	284b1bbff58d471c4016f9caf51cd415a313995c	link	true	/test e2e-agnostic-operator
ci/prow/versions	284b1bbff58d471c4016f9caf51cd415a313995c	link	false	/test versions
ci/prow/e2e-aws-ovn-techpreview	284b1bbff58d471c4016f9caf51cd415a313995c	link	true	/test e2e-aws-ovn-techpreview

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).

[mandre]

Closing in favor of https://github.com/openshift/cluster-monitoring-operator/pull/2430. We want to use a more dynamic approach for collecting the needed annotation thanks to CRS. /close

[openshift-ci[bot]]

@mandre: Closed this PR.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2428#issuecomment-2265409374): >Closing in favor of https://github.com/openshift/cluster-monitoring-operator/pull/2430. We want to use a more dynamic approach for collecting the needed annotation thanks to CRS. >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.