search

openshift / cluster-monitoring-operator

Manage the OpenShift monitoring stack
Apache License 2.0
247 stars 363 forks source link

Remove `kube_*_annotations` and `kube_*_labels` from deny list #2430

Open mandre opened 2 months ago

mandre commented 2 months ago

Since https://github.com/kubernetes/kube-state-metrics/pull/2145, kube-state-metrics does not collect kube_*_annotations or kube_*_labels metrics by default. It's no longer necessary to add them to the metrics' deny list.

Removing kube_*_annotations from the deny list allows us to enable scrapping of annotation metrics via the --metric-annotations-allowlist option.

Additionally, we were missing a comma, which might have been a problem in the comma-separated list of arguments.

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mandre Once this PR has been reviewed and has the lgtm label, please assign rexagod for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/cluster-monitoring-operator/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
juzhao commented 1 month ago

/retest

juzhao commented 1 month ago

/label qe-approved

openshift-ci[bot] commented 1 month ago

@mandre: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).