search

openshift / cluster-monitoring-operator

Manage the OpenShift monitoring stack
Apache License 2.0
247 stars 363 forks source link

[release-4.14] OCPBUGS-37468: Backport of PR #2384 #2433

Closed JoshSalomon closed 2 months ago

JoshSalomon commented 2 months ago

This is a backport to release 4.14z of PR #2384 for monitoring the ipsec state metric that CNO exports. This is not a cherry-pick since cherry-picking created conflicts in the generated files, and it was simpler to regenerate them instead of resolving the conflicts.

openshift-ci-robot commented 2 months ago

@JoshSalomon: This pull request references Jira Issue OCPBUGS-37468, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.14.z) matches configured target version for branch (4.14.z) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST) * release note text is set and does not match the template * dependent bug [Jira Issue OCPBUGS-34596](https://issues.redhat.com//browse/OCPBUGS-34596) is in the state Closed (Done-Errata), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA)) * dependent [Jira Issue OCPBUGS-34596](https://issues.redhat.com//browse/OCPBUGS-34596) targets the "4.15.z" version, which is one of the valid target versions: 4.15.0, 4.15.z * bug has dependents

Requesting review from QA contact: /cc @huiran0826

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2433): >This is a backport to release 4.14z of PR #2384 for monitoring the ipsec state metric that CNO exports. >This is not a cherry-pick since cherry-picking created conflicts in the generated files, and it was simpler to regenerate them instead of resolving the conflicts. > > > >* [ ] I added CHANGELOG entry for this change. >* [ ] No user facing changes, so no entry in CHANGELOG was needed. > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 2 months ago

@JoshSalomon: This pull request references Jira Issue OCPBUGS-37468, which is valid.

7 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.14.z) matches configured target version for branch (4.14.z) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST) * release note text is set and does not match the template * dependent bug [Jira Issue OCPBUGS-34596](https://issues.redhat.com//browse/OCPBUGS-34596) is in the state Closed (Done-Errata), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA)) * dependent [Jira Issue OCPBUGS-34596](https://issues.redhat.com//browse/OCPBUGS-34596) targets the "4.15.z" version, which is one of the valid target versions: 4.15.0, 4.15.z * bug has dependents

Requesting review from QA contact: /cc @huiran0826

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2433): >This is a backport to release 4.14z of PR #2384 for monitoring the ipsec state metric that CNO exports. >This is not a cherry-pick since cherry-picking created conflicts in the generated files, and it was simpler to regenerate them instead of resolving the conflicts. > > > >* [ ] I added CHANGELOG entry for this change. >* [ ] No user facing changes, so no entry in CHANGELOG was needed. > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 2 months ago

@JoshSalomon: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
simonpasquier commented 2 months ago

/label backport-risk-assessed

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoshSalomon, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-monitoring-operator/blob/release-4.14/OWNERS)~~ [simonpasquier] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
juzhao commented 2 months ago

/label cherry-pick-approved

openshift-ci-robot commented 2 months ago

@JoshSalomon: Jira Issue OCPBUGS-37468: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-37468 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2433): >This is a backport to release 4.14z of PR #2384 for monitoring the ipsec state metric that CNO exports. >This is not a cherry-pick since cherry-picking created conflicts in the generated files, and it was simpler to regenerate them instead of resolving the conflicts. > > > >* [ ] I added CHANGELOG entry for this change. >* [ ] No user facing changes, so no entry in CHANGELOG was needed. > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 2 months ago

[ART PR BUILD NOTIFIER]

Distgit: cluster-monitoring-operator This PR has been included in build cluster-monitoring-operator-container-v4.14.0-202408081513.p0.gde39c40.assembly.stream.el8. All builds following this will include this PR.

openshift-merge-robot commented 2 months ago

Fix included in accepted release 4.14.0-0.nightly-2024-08-08-211032