OCPBUGS-33863: use UserWorkloadInvalidConfiguration reason when UWM config only is invalid

machine424 commented 2 months ago

If the Platform configuration is invalid or both configurations are invalid, the reason will still be InvalidConfiguration

[ ] I added CHANGELOG entry for this change.
[ ] No user facing changes, so no entry in CHANGELOG was needed.

openshift-ci-robot commented 2 months ago

@machine424: This pull request references Jira Issue OCPBUGS-33863, which is invalid:

expected the bug to target the "4.18.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2436): >If the Platform configuration is invalid or both configurations are invalid, the reason will still be InvalidConfiguration > > > >* [ ] I added CHANGELOG entry for this change. >* [ ] No user facing changes, so no entry in CHANGELOG was needed. > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

machine424 commented 2 months ago

/retest

juzhao commented 2 months ago

/jira refresh

openshift-ci-robot commented 2 months ago

@juzhao: This pull request references Jira Issue OCPBUGS-33863, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

* bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @juzhao

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2436#issuecomment-2285889064): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

juzhao commented 2 months ago

ci/prow/e2e-aws-ovn-techpreview failed https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_cluster-monitoring-operator/2436/pull-ci-openshift-cluster-monitoring-operator-master-e2e-aws-ovn-techpreview/1823083622240882688

: [sig-instrumentation][Late] Alerts shouldn't exceed the series limit of total series sent via telemetry from each cluster [Suite:openshift/conformance/parallel] expand_less
Run #0: Failed expand_less  55s
{  fail [github.com/openshift/origin/test/extended/prometheus/prometheus.go:409]: Unexpected error:
    <errors.aggregate | len:1, cap:1>: 
    promQL query returned unexpected results:
    avg_over_time(cluster:telemetry_selected_series:count[43m16s]) >= 760
    [
      {
        "metric": {
          "prometheus": "openshift-monitoring/k8s"
        },
        "value": [
          1723497179.24,
          "763.8275862068965"
        ]
      }
    ]
    [
        <*errors.errorString | 0xc001885410>{
            s: "promQL query returned unexpected results:\navg_over_time(cluster:telemetry_selected_series:count[43m16s]) >= 760\n[\n  {\n    \"metric\": {\n      \"prometheus\": \"openshift-monitoring/k8s\"\n    },\n    \"value\": [\n      1723497179.24,\n      \"763.8275862068965\"\n    ]\n  }\n]",
        },
    ]
occurred
Ginkgo exit error 1: exit with code 1}
[open stdoutopen_in_new](https://prow.ci.openshift.org/spyglass/lens/junit/iframe?req=%7B%22artifacts%22%3A%5B%22artifacts%2Fe2e-aws-ovn-techpreview%2Fgather-extra%2Fartifacts%2Fjunit%2Fjunit_install_status.xml%22%2C%22artifacts%2Fe2e-aws-ovn-techpreview%2Fgather-extra%2Fartifacts%2Fjunit%2Fjunit_symptoms.xml%22%2C%22artifacts%2Fe2e-aws-ovn-techpreview%2Fgather-must-gather%2Fartifacts%2Fjunit_install.xml%22%2C%22artifacts%2Fe2e-aws-ovn-techpreview%2Fopenshift-e2e-test%2Fartifacts%2Fjunit%2Fe2e-monitor-tests__20240812-202903.xml%22%2C%22artifacts%2Fe2e-aws-ovn-techpreview%2Fopenshift-e2e-test%2Fartifacts%2Fjunit%2Fjunit_e2e__20240812-202903.xml%22%2C%22artifacts%2Fe2e-aws-ovn-techpreview%2Fopenshift-e2e-test%2Fartifacts%2Fjunit_node_ready.xml%22%2C%22artifacts%2Fe2e-aws-ovn-techpreview%2Fopenshift-e2e-test%2Fartifacts%2Fjunit_nodes.xml%22%2C%22artifacts%2Fjunit_operator.xml%22%5D%2C%22index%22%3A2%2C%22src%22%3A%22gs%2Ftest-platform-results%2Fpr-logs%2Fpull%2Fopenshift_cluster-monitoring-operator%2F2436%2Fpull-ci-openshift-cluster-monitoring-operator-master-e2e-aws-ovn-techpreview%2F1823083622240882688%22%7D&topURL=https%3A//prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_cluster-monitoring-operator/2436/pull-ci-openshift-cluster-monitoring-operator-master-e2e-aws-ovn-techpreview/1823083622240882688&lensIndex=2#)
Run #1: Failed expand_less  53s
{  fail [github.com/openshift/origin/test/extended/prometheus/prometheus.go:409]: Unexpected error:
    <errors.aggregate | len:1, cap:1>: 
    promQL query returned unexpected results:
    avg_over_time(cluster:telemetry_selected_series:count[44m9s]) >= 760
    [
      {
        "metric": {
          "prometheus": "openshift-monitoring/k8s"
        },
        "value": [
          1723497232.174,
          "764.1363636363636"
        ]
      }
    ]
    [
        <*errors.errorString | 0xc0014b7d70>{
            s: "promQL query returned unexpected results:\navg_over_time(cluster:telemetry_selected_series:count[44m9s]) >= 760\n[\n  {\n    \"metric\": {\n      \"prometheus\": \"openshift-monitoring/k8s\"\n    },\n    \"value\": [\n      1723497232.174,\n      \"764.1363636363636\"\n    ]\n  }\n]",
        },
    ]
occurred
Ginkgo exit error 1: exit with code 1}

limit is 760, not sure if we need to increase it https://github.com/openshift/origin/blob/master/test/extended/prometheus/prometheus.go#L405

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jan--f, machine424

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-monitoring-operator/blob/master/OWNERS)~~ [jan--f,machine424] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

openshift-ci-robot commented 2 months ago

/retest-required

Remaining retests: 0 against base HEAD 6525b004c7eb696d2c3d83e3e3ef5bfc510ed01a and 2 for PR HEAD 545257e269b752285ac0bef1e5fc394180d632bb in total

machine424 commented 2 months ago

ci/prow/e2e-aws-ovn-techpreview failed https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_cluster-monitoring-operator/2436/pull-ci-openshift-cluster-monitoring-operator-master-e2e-aws-ovn-techpreview/1823083622240882688

: [sig-instrumentation][Late] Alerts shouldn't exceed the series limit of total series sent via telemetry from each cluster [Suite:openshift/conformance/parallel] expand_less
Run #0: Failed expand_less    55s
{  fail [github.com/openshift/origin/test/extended/prometheus/prometheus.go:409]: Unexpected error:
    <errors.aggregate | len:1, cap:1>: 
    promQL query returned unexpected results:
    avg_over_time(cluster:telemetry_selected_series:count[43m16s]) >= 760
    [
      {
        "metric": {
          "prometheus": "openshift-monitoring/k8s"
        },
        "value": [
          1723497179.24,
          "763.8275862068965"
        ]
      }
    ]
    [
        <*errors.errorString | 0xc001885410>{
            s: "promQL query returned unexpected results:\navg_over_time(cluster:telemetry_selected_series:count[43m16s]) >= 760\n[\n  {\n    \"metric\": {\n      \"prometheus\": \"openshift-monitoring/k8s\"\n    },\n    \"value\": [\n      1723497179.24,\n      \"763.8275862068965\"\n    ]\n  }\n]",
        },
    ]
occurred
Ginkgo exit error 1: exit with code 1}
[open stdoutopen_in_new](https://prow.ci.openshift.org/spyglass/lens/junit/iframe?req=%7B%22artifacts%22%3A%5B%22artifacts%2Fe2e-aws-ovn-techpreview%2Fgather-extra%2Fartifacts%2Fjunit%2Fjunit_install_status.xml%22%2C%22artifacts%2Fe2e-aws-ovn-techpreview%2Fgather-extra%2Fartifacts%2Fjunit%2Fjunit_symptoms.xml%22%2C%22artifacts%2Fe2e-aws-ovn-techpreview%2Fgather-must-gather%2Fartifacts%2Fjunit_install.xml%22%2C%22artifacts%2Fe2e-aws-ovn-techpreview%2Fopenshift-e2e-test%2Fartifacts%2Fjunit%2Fe2e-monitor-tests__20240812-202903.xml%22%2C%22artifacts%2Fe2e-aws-ovn-techpreview%2Fopenshift-e2e-test%2Fartifacts%2Fjunit%2Fjunit_e2e__20240812-202903.xml%22%2C%22artifacts%2Fe2e-aws-ovn-techpreview%2Fopenshift-e2e-test%2Fartifacts%2Fjunit_node_ready.xml%22%2C%22artifacts%2Fe2e-aws-ovn-techpreview%2Fopenshift-e2e-test%2Fartifacts%2Fjunit_nodes.xml%22%2C%22artifacts%2Fjunit_operator.xml%22%5D%2C%22index%22%3A2%2C%22src%22%3A%22gs%2Ftest-platform-results%2Fpr-logs%2Fpull%2Fopenshift_cluster-monitoring-operator%2F2436%2Fpull-ci-openshift-cluster-monitoring-operator-master-e2e-aws-ovn-techpreview%2F1823083622240882688%22%7D&topURL=https%3A//prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_cluster-monitoring-operator/2436/pull-ci-openshift-cluster-monitoring-operator-master-e2e-aws-ovn-techpreview/1823083622240882688&lensIndex=2#)
Run #1: Failed expand_less    53s
{  fail [github.com/openshift/origin/test/extended/prometheus/prometheus.go:409]: Unexpected error:
    <errors.aggregate | len:1, cap:1>: 
    promQL query returned unexpected results:
    avg_over_time(cluster:telemetry_selected_series:count[44m9s]) >= 760
    [
      {
        "metric": {
          "prometheus": "openshift-monitoring/k8s"
        },
        "value": [
          1723497232.174,
          "764.1363636363636"
        ]
      }
    ]
    [
        <*errors.errorString | 0xc0014b7d70>{
            s: "promQL query returned unexpected results:\navg_over_time(cluster:telemetry_selected_series:count[44m9s]) >= 760\n[\n  {\n    \"metric\": {\n      \"prometheus\": \"openshift-monitoring/k8s\"\n    },\n    \"value\": [\n      1723497232.174,\n      \"764.1363636363636\"\n    ]\n  }\n]",
        },
    ]
occurred
Ginkgo exit error 1: exit with code 1}

limit is 760, not sure if we need to increase it https://github.com/openshift/origin/blob/master/test/extended/prometheus/prometheus.go#L405

Yes, we'll need to increase that, if justified.

openshift-ci[bot] commented 2 months ago

@machine424: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).

openshift-ci-robot commented 2 months ago

@machine424: Jira Issue OCPBUGS-33863: All pull requests linked via external trackers have merged:

openshift/cluster-monitoring-operator#2436

Jira Issue OCPBUGS-33863 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2436): >If the Platform configuration is invalid or both configurations are invalid, the reason will still be InvalidConfiguration > > > >* [ ] I added CHANGELOG entry for this change. >* [ ] No user facing changes, so no entry in CHANGELOG was needed. > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

openshift / cluster-monitoring-operator

OCPBUGS-33863: use UserWorkloadInvalidConfiguration reason when UWM config only is invalid #2436