openshift / cluster-monitoring-operator

Manage the OpenShift monitoring stack
Apache License 2.0
247 stars 363 forks source link

MON-4021: feat: add the required utils for automated tests and integration with the docs #2443

Closed machine424 closed 4 days ago

machine424 commented 1 month ago

add the required utils to integrate the scenarios scripts testing into CMO e2e tests.

add utils to integrate the scripts with the docs, for now in "Documentation/resources" below the corresponding 'port/RBAC permission'

add an example for how to setup RBAC and access the APIs exposed at openshift-monitoring/alertmanager-main port 9094

openshift-ci-robot commented 1 month ago

@machine424: This pull request references MON-4021 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2443): > > >* [ ] I added CHANGELOG entry for this change. >* [ ] No user facing changes, so no entry in CHANGELOG was needed. > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 1 month ago

@machine424: This pull request references MON-4021 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2443): >add the required utils to integrate the scenarios scripts testing into CMO e2e tests. > >add utils to integrate the scripts with the docs, for now in "Documentation/resources" below the corresponding > 'port/RBAC permission' > >add an example for how to setup RBAC and access the APIs exposed at openshift-monitoring/alertmanager-main port 9094 > > > > > >* [ ] I added CHANGELOG entry for this change. >* [ ] No user facing changes, so no entry in CHANGELOG was needed. > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
machine424 commented 4 days ago

Overall LGTM, but would you mind adding some additional docs on how the workflow of this change would be? You can do it in an additional PR if you don't want to modify this one. Thanks!

Yes, I'll take care of the docs. This will need another /lgtm, thanks.

danielmellado commented 4 days ago

/lgtm

openshift-ci[bot] commented 4 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danielmellado, machine424

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-monitoring-operator/blob/master/OWNERS)~~ [danielmellado,machine424] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 4 days ago

/retest-required

Remaining retests: 0 against base HEAD 214adadad34f31639b554cfa962941d55f9eea6b and 2 for PR HEAD 151ea14a2b9a85838b5cc6197e1a51b2a93e3efe in total

openshift-ci[bot] commented 4 days ago

@machine424: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-bot commented 4 days ago

[ART PR BUILD NOTIFIER]

Distgit: cluster-monitoring-operator This PR has been included in build cluster-monitoring-operator-container-v4.18.0-202410161343.p0.g2ab9427.assembly.stream.el9. All builds following this will include this PR.