Closed machine424 closed 4 days ago
@machine424: This pull request references MON-4021 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.18.0" version, but no target version was set.
@machine424: This pull request references MON-4021 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.18.0" version, but no target version was set.
Overall LGTM, but would you mind adding some additional docs on how the workflow of this change would be? You can do it in an additional PR if you don't want to modify this one. Thanks!
Yes, I'll take care of the docs.
This will need another /lgtm
, thanks.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: danielmellado, machine424
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/retest-required
Remaining retests: 0 against base HEAD 214adadad34f31639b554cfa962941d55f9eea6b and 2 for PR HEAD 151ea14a2b9a85838b5cc6197e1a51b2a93e3efe in total
@machine424: all tests passed!
Full PR test history. Your PR dashboard.
[ART PR BUILD NOTIFIER]
Distgit: cluster-monitoring-operator This PR has been included in build cluster-monitoring-operator-container-v4.18.0-202410161343.p0.g2ab9427.assembly.stream.el9. All builds following this will include this PR.
add the required utils to integrate the scenarios scripts testing into CMO e2e tests.
add utils to integrate the scripts with the docs, for now in "Documentation/resources" below the corresponding 'port/RBAC permission'
add an example for how to setup RBAC and access the APIs exposed at openshift-monitoring/alertmanager-main port 9094