openshift / cluster-monitoring-operator

Manage the OpenShift monitoring stack
Apache License 2.0
247 stars 363 forks source link

MON-3990: make TestClusterMonitorConsolePlugin check that one of the pods can serve /plugin-manifest.json #2444

Closed machine424 closed 1 month ago

machine424 commented 1 month ago

… pods can serve /plugin-manifest.json

This is all the more important since the plugin Pods do not have readiness probes.

A more realistic test would ensure the console can reach the plusgins, that can be added in origin/

machine424 commented 1 month ago

/retest

machine424 commented 1 month ago

/retest

machine424 commented 1 month ago

/retitle MON-3990: make TestClusterMonitorConsolePlugin check that one of the pods can serve /plugin-manifest.json

openshift-ci-robot commented 1 month ago

@machine424: This pull request references MON-3990 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2444): >… pods can serve /plugin-manifest.json > >This is all the more important since the plugin Pods do not have readiness probes. > >A more realistic test would ensure the console can reach the plusgins, that can be added in origin/ > > > >* [ ] I added CHANGELOG entry for this change. >* [ ] No user facing changes, so no entry in CHANGELOG was needed. > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
machine424 commented 1 month ago

Note that a readinessProbe will as well be added for the new Go backend https://github.com/openshift/cluster-monitoring-operator/pull/2412#issuecomment-2315085438

machine424 commented 1 month ago

/jira refresh

openshift-ci-robot commented 1 month ago

@machine424: This pull request references MON-3990 which is a valid jira issue.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2444#issuecomment-2315744503): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
machine424 commented 1 month ago

/retest

openshift-ci[bot] commented 1 month ago

@machine424: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: machine424, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-monitoring-operator/blob/master/OWNERS)~~ [machine424,simonpasquier] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-bot commented 1 month ago

[ART PR BUILD NOTIFIER]

Distgit: cluster-monitoring-operator This PR has been included in build cluster-monitoring-operator-container-v4.18.0-202408301116.p0.ge5a5bc2.assembly.stream.el9. All builds following this will include this PR.