search

openshift / cluster-monitoring-operator

Manage the OpenShift monitoring stack
Apache License 2.0
247 stars 363 forks source link

OCPBUGS-42067: Reapply "chore: poll immediately in the e2e tests" #2476

Closed simonpasquier closed 1 month ago

simonpasquier commented 1 month ago

This reverts commit 10160fd3fefb3791121ad8f5b8bf043938085884.

simonpasquier commented 1 month ago

/cc @machine424

machine424 commented 1 month ago

Discussed offline, let's give this a try, thanks. /lgtm

simonpasquier commented 1 month ago

/label backport-risk-assessed

I'll wait for the e2e tests to complete before submitting the JIRA tickets.

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: machine424, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-monitoring-operator/blob/release-4.16/OWNERS)~~ [machine424,simonpasquier] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
simonpasquier commented 1 month ago

/skip

simonpasquier commented 1 month ago

/jira cherrypick OCPBUGS-42066

openshift-ci-robot commented 1 month ago

@simonpasquier: Jira Issue OCPBUGS-42066 has been cloned as Jira Issue OCPBUGS-42067. Will retitle bug to link to clone. /retitle OCPBUGS-42067: WIP: Reapply "chore: poll immediately in the e2e tests"

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2476#issuecomment-2354757138): >/jira cherrypick OCPBUGS-42066 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 1 month ago

@simonpasquier: This pull request references Jira Issue OCPBUGS-42067, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.16.z) matches configured target version for branch (4.16.z) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST) * release note text is set and does not match the template * dependent bug [Jira Issue OCPBUGS-42066](https://issues.redhat.com//browse/OCPBUGS-42066) is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA)) * dependent [Jira Issue OCPBUGS-42066](https://issues.redhat.com//browse/OCPBUGS-42066) targets the "4.17.0" version, which is one of the valid target versions: 4.17.0 * bug has dependents

Requesting review from QA contact: /cc @juzhao

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2476): >This reverts commit 10160fd3fefb3791121ad8f5b8bf043938085884. > > > >* [ ] I added CHANGELOG entry for this change. >* [ ] No user facing changes, so no entry in CHANGELOG was needed. > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
simonpasquier commented 1 month ago

From the e2e-agnostic-operator job run

Step phase test succeeded after 1h33m48s
juzhao commented 1 month ago

/label cherry-pick-approved /label qe-approved

openshift-ci-robot commented 1 month ago

@simonpasquier: This pull request references Jira Issue OCPBUGS-42067, which is valid.

7 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.16.z) matches configured target version for branch (4.16.z) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST) * release note text is set and does not match the template * dependent bug [Jira Issue OCPBUGS-42066](https://issues.redhat.com//browse/OCPBUGS-42066) is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA)) * dependent [Jira Issue OCPBUGS-42066](https://issues.redhat.com//browse/OCPBUGS-42066) targets the "4.17.0" version, which is one of the valid target versions: 4.17.0 * bug has dependents

Requesting review from QA contact: /cc @juzhao

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2476): >This reverts commit 10160fd3fefb3791121ad8f5b8bf043938085884. > > > >* [ ] I added CHANGELOG entry for this change. >* [ ] No user facing changes, so no entry in CHANGELOG was needed. > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
simonpasquier commented 1 month ago

/retest-required

openshift-ci[bot] commented 1 month ago

@simonpasquier: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node 04228d4c3f4c6d08af25b4e71aed231d2a892796 link false /test e2e-aws-ovn-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD 7284152275444a6db267298f410a8b4fbfb7490c and 2 for PR HEAD 04228d4c3f4c6d08af25b4e71aed231d2a892796 in total

openshift-ci-robot commented 1 month ago

@simonpasquier: Jira Issue OCPBUGS-42067: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-42067 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2476): >This reverts commit 10160fd3fefb3791121ad8f5b8bf043938085884. > > > >* [ ] I added CHANGELOG entry for this change. >* [ ] No user facing changes, so no entry in CHANGELOG was needed. > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 4 weeks ago

[ART PR BUILD NOTIFIER]

Distgit: cluster-monitoring-operator This PR has been included in build cluster-monitoring-operator-container-v4.16.0-202409202304.p0.ga9386a2.assembly.stream.el9. All builds following this will include this PR.

openshift-merge-robot commented 3 weeks ago

Fix included in accepted release 4.16.0-0.nightly-2024-09-22-173535