openshift / cluster-monitoring-operator

Manage the OpenShift monitoring stack
Apache License 2.0
247 stars 363 forks source link

NO-JIRA: vendor Kubernetes dashboards #2482

Closed simonpasquier closed 3 weeks ago

simonpasquier commented 3 weeks ago

kubernetes-monitoring/kubernetes-mixin is pinned to the latest upstream commit before the project switched to Grafana v11 since it broke the Kubernetes dashboards in the OCP console (see 2399dc84 for details).

This change removes the Kubernetes dashboards from the jsonnet generation code. Instead their current version is copied to the 0000_90_cluster-monitoring-operator_02-dashboards.yaml file under the manifests/ directory. Any future update to these dashboards should be made to the manifest file directly.

A follow-up PR will unpin the kubernetes-monitoring/kubernetes-mixin version.

openshift-ci-robot commented 3 weeks ago

@simonpasquier: This pull request explicitly references no jira issue.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2482): >kubernetes-monitoring/kubernetes-mixin is pinned to the latest upstream commit before the project switched to Grafana v11 since it broke the Kubernetes dashboards in the OCP console (see 2399dc84 for details). > >This change removes the Kubernetes dashboards from the jsonnet generation code. Instead their current version is copied to the `0000_90_cluster-monitoring-operator_02-dashboards.yaml` file under the `manifests/` directory. Any future update to these dashboards should be made to the manifest file directly. > >A follow-up PR will unpin the kubernetes-monitoring/kubernetes-mixin version. > > > >* [ ] I added CHANGELOG entry for this change. >* [ ] No user facing changes, so no entry in CHANGELOG was needed. > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
simonpasquier commented 3 weeks ago

/hold

I want to spin up a test cluster and compare against the current version.

simonpasquier commented 3 weeks ago

/hold cancel tested locally and it seems working.

rexagod commented 3 weeks ago

/retest /approve

Unblocks https://github.com/openshift/cluster-monitoring-operator/pull/2422.

rexagod commented 3 weeks ago

/lgtm

openshift-ci-robot commented 3 weeks ago

/retest-required

Remaining retests: 0 against base HEAD af93eec3978fc351b22177fe40c5e0537f326fd6 and 2 for PR HEAD 5f81832ea89ab097701a8a9cd246e5b923ce64c6 in total

openshift-ci[bot] commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marioferh, rexagod, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-monitoring-operator/blob/master/OWNERS)~~ [marioferh,rexagod,simonpasquier] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 3 weeks ago

/retest-required

Remaining retests: 0 against base HEAD 9a4e071f701ff9738046a9e83add3d8c60c05051 and 2 for PR HEAD 5f81832ea89ab097701a8a9cd246e5b923ce64c6 in total

openshift-ci-robot commented 3 weeks ago

/retest-required

Remaining retests: 0 against base HEAD 9a4e071f701ff9738046a9e83add3d8c60c05051 and 2 for PR HEAD 5f81832ea89ab097701a8a9cd246e5b923ce64c6 in total

simonpasquier commented 3 weeks ago

/retest-required

simonpasquier commented 3 weeks ago

/retest-required

openshift-ci-robot commented 3 weeks ago

/retest-required

Remaining retests: 0 against base HEAD 9a4e071f701ff9738046a9e83add3d8c60c05051 and 2 for PR HEAD 5f81832ea89ab097701a8a9cd246e5b923ce64c6 in total

simonpasquier commented 3 weeks ago

/test e2e-hypershift-conformance

openshift-ci[bot] commented 3 weeks ago

@simonpasquier: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-bot commented 3 weeks ago

[ART PR BUILD NOTIFIER]

Distgit: cluster-monitoring-operator This PR has been included in build cluster-monitoring-operator-container-v4.18.0-202409242009.p0.g9f8c85a.assembly.stream.el9. All builds following this will include this PR.