Closed simonpasquier closed 3 weeks ago
@simonpasquier: This pull request explicitly references no jira issue.
/hold
I want to spin up a test cluster and compare against the current version.
/hold cancel tested locally and it seems working.
/retest /approve
Unblocks https://github.com/openshift/cluster-monitoring-operator/pull/2422.
/lgtm
/retest-required
Remaining retests: 0 against base HEAD af93eec3978fc351b22177fe40c5e0537f326fd6 and 2 for PR HEAD 5f81832ea89ab097701a8a9cd246e5b923ce64c6 in total
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: marioferh, rexagod, simonpasquier
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/retest-required
Remaining retests: 0 against base HEAD 9a4e071f701ff9738046a9e83add3d8c60c05051 and 2 for PR HEAD 5f81832ea89ab097701a8a9cd246e5b923ce64c6 in total
/retest-required
Remaining retests: 0 against base HEAD 9a4e071f701ff9738046a9e83add3d8c60c05051 and 2 for PR HEAD 5f81832ea89ab097701a8a9cd246e5b923ce64c6 in total
/retest-required
/retest-required
/retest-required
Remaining retests: 0 against base HEAD 9a4e071f701ff9738046a9e83add3d8c60c05051 and 2 for PR HEAD 5f81832ea89ab097701a8a9cd246e5b923ce64c6 in total
/test e2e-hypershift-conformance
@simonpasquier: all tests passed!
Full PR test history. Your PR dashboard.
[ART PR BUILD NOTIFIER]
Distgit: cluster-monitoring-operator This PR has been included in build cluster-monitoring-operator-container-v4.18.0-202409242009.p0.g9f8c85a.assembly.stream.el9. All builds following this will include this PR.
kubernetes-monitoring/kubernetes-mixin is pinned to the latest upstream commit before the project switched to Grafana v11 since it broke the Kubernetes dashboards in the OCP console (see 2399dc84 for details).
This change removes the Kubernetes dashboards from the jsonnet generation code. Instead their current version is copied to the
0000_90_cluster-monitoring-operator_02-dashboards.yaml
file under themanifests/
directory. Any future update to these dashboards should be made to the manifest file directly.A follow-up PR will unpin the kubernetes-monitoring/kubernetes-mixin version.