openshift / cluster-monitoring-operator

Manage the OpenShift monitoring stack
Apache License 2.0
247 stars 363 forks source link

[release-4.15] OCPBUGS-42586: Exclude windows nodes from kubelet servicemonitor #2487

Closed openshift-cherrypick-robot closed 2 weeks ago

openshift-cherrypick-robot commented 2 weeks ago

This is an automated cherry-pick of #2408

/assign slashpai

openshift-ci-robot commented 2 weeks ago

@openshift-cherrypick-robot: Jira Issue OCPBUGS-36717 has been cloned as Jira Issue OCPBUGS-42586. Will retitle bug to link to clone. /retitle [release-4.15] OCPBUGS-42586: Exclude windows nodes from kubelet servicemonitor

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2487): >This is an automated cherry-pick of #2408 > >/assign slashpai Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 2 weeks ago

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-42586, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.15.z) matches configured target version for branch (4.15.z) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST) * release note text is set and does not match the template * dependent bug [Jira Issue OCPBUGS-36717](https://issues.redhat.com//browse/OCPBUGS-36717) is in the state Closed (Done-Errata), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA)) * dependent [Jira Issue OCPBUGS-36717](https://issues.redhat.com//browse/OCPBUGS-36717) targets the "4.16.z" version, which is one of the valid target versions: 4.16.0, 4.16.z * bug has dependents

Requesting review from QA contact: /cc @juzhao

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2487): >This is an automated cherry-pick of #2408 > >/assign slashpai Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
slashpai commented 2 weeks ago

/lgtm

openshift-ci[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, slashpai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-monitoring-operator/blob/release-4.15/OWNERS)~~ [slashpai] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
simonpasquier commented 2 weeks ago

/label backport-risk-assessed

juzhao commented 2 weeks ago

/label cherry-pick-approved

openshift-ci[bot] commented 2 weeks ago

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 2 weeks ago

@openshift-cherrypick-robot: Jira Issue OCPBUGS-42586: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-42586 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2487): >This is an automated cherry-pick of #2408 > >/assign slashpai Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
slashpai commented 2 weeks ago

/cherry-pick release-4.14

openshift-cherrypick-robot commented 2 weeks ago

@slashpai: new pull request created: #2488

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2487#issuecomment-2383386671): >/cherry-pick release-4.14 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-bot commented 2 weeks ago

[ART PR BUILD NOTIFIER]

Distgit: cluster-monitoring-operator This PR has been included in build cluster-monitoring-operator-container-v4.15.0-202409301407.p0.g4275516.assembly.stream.el9. All builds following this will include this PR.

openshift-merge-robot commented 2 weeks ago

Fix included in accepted release 4.15.0-0.nightly-2024-09-30-184358