search

openshift / cluster-monitoring-operator

Manage the OpenShift monitoring stack
Apache License 2.0
247 stars 363 forks source link

[release-4.14] OCPBUGS-42603: Exclude windows nodes from kubelet servicemonitor #2488

Closed openshift-cherrypick-robot closed 2 weeks ago

openshift-cherrypick-robot commented 2 weeks ago

This is an automated cherry-pick of #2487

/assign slashpai

openshift-ci-robot commented 2 weeks ago

@openshift-cherrypick-robot: Jira Issue OCPBUGS-42586 has been cloned as Jira Issue OCPBUGS-42603. Will retitle bug to link to clone. /retitle [release-4.14] OCPBUGS-42603: Exclude windows nodes from kubelet servicemonitor

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2488): >This is an automated cherry-pick of #2487 > >/assign slashpai Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openshift-cherrypick-robot Once this PR has been reviewed and has the lgtm label, please ask for approval from slashpai. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/cluster-monitoring-operator/blob/release-4.14/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 2 weeks ago

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-42603, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2488): >This is an automated cherry-pick of #2487 > >/assign slashpai Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
slashpai commented 2 weeks ago

/retest

openshift-ci[bot] commented 2 weeks ago

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/generate 973308fd4802249ea732709ac2b5e5f16e66eee2 link true /test generate

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
slashpai commented 2 weeks ago

/close

created https://github.com/openshift/cluster-monitoring-operator/pull/2488 to fix generate command issue

openshift-ci[bot] commented 2 weeks ago

@slashpai: Closed this PR.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2488#issuecomment-2390566570): >/close > >created https://github.com/openshift/cluster-monitoring-operator/pull/2488 to fix generate command issue Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 2 weeks ago

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-42603. The bug has been updated to no longer refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2488): >This is an automated cherry-pick of #2487 > >/assign slashpai Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.