openshift / cluster-monitoring-operator

Manage the OpenShift monitoring stack
Apache License 2.0
247 stars 363 forks source link

[release-4.14] OCPBUGS-42603: Exclude windows nodes from kubelet servicemonitor #2489

Closed slashpai closed 1 week ago

slashpai commented 2 weeks ago

overrides https://github.com/openshift/cluster-monitoring-operator/pull/2488

openshift-ci-robot commented 2 weeks ago

@slashpai: This pull request references Jira Issue OCPBUGS-42603, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2489): >overrides https://github.com/openshift/cluster-monitoring-operator/pull/2488 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
simonpasquier commented 2 weeks ago

/label backport-risk-assessed

jan--f commented 2 weeks ago

/lgtm /label backport-risk-assessed

openshift-ci[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jan--f, slashpai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-monitoring-operator/blob/release-4.14/OWNERS)~~ [jan--f,slashpai] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
slashpai commented 2 weeks ago

/retest

slashpai commented 2 weeks ago

/retest-required

openshift-ci[bot] commented 2 weeks ago

@slashpai: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
slashpai commented 2 weeks ago

cc @juzhao

slashpai commented 1 week ago

/jira refresh

openshift-ci-robot commented 1 week ago

@slashpai: This pull request references Jira Issue OCPBUGS-42603, which is valid.

7 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.14.z) matches configured target version for branch (4.14.z) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST) * release note text is set and does not match the template * dependent bug [Jira Issue OCPBUGS-42586](https://issues.redhat.com//browse/OCPBUGS-42586) is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA)) * dependent [Jira Issue OCPBUGS-42586](https://issues.redhat.com//browse/OCPBUGS-42586) targets the "4.15.z" version, which is one of the valid target versions: 4.15.0, 4.15.z * bug has dependents

Requesting review from QA contact: /cc @juzhao

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2489#issuecomment-2398905392): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
slashpai commented 1 week ago

@juzhao can you review?

juzhao commented 1 week ago

/label cherry-pick-approved

openshift-ci-robot commented 1 week ago

@slashpai: Jira Issue OCPBUGS-42603: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-42603 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2489): >overrides https://github.com/openshift/cluster-monitoring-operator/pull/2488 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 1 week ago

[ART PR BUILD NOTIFIER]

Distgit: cluster-monitoring-operator This PR has been included in build cluster-monitoring-operator-container-v4.14.0-202410101139.p0.g6264a94.assembly.stream.el8. All builds following this will include this PR.

openshift-merge-robot commented 1 week ago

Fix included in accepted release 4.14.0-0.nightly-2024-10-10-183431