openshift / cluster-monitoring-operator

Manage the OpenShift monitoring stack
Apache License 2.0
247 stars 363 forks source link

MON-4054: Remove temporary no more needed code #2496

Open machine424 opened 4 days ago

machine424 commented 4 days ago

pkg/tasks/prometheusoperator.go: Remove code introduced in https://github.com/openshift/cluster-monitoring-operator/pull/1806

pkg/tasks/{prometheus.go, thanos_ruler_user_workload.go, thanos_querier.go}: Remove cleanup code added in https://github.com/openshift/cluster-monitoring-operator/pull/1731

Was done for 4.15 in https://github.com/openshift/cluster-monitoring-operator/pull/2132

Make some users who don't want to see the unnecessary 404 on 4.14, happy.

openshift-ci-robot commented 4 days ago

@machine424: This pull request references MON-3422 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.14.z" version, but no target version was set.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2496): >pkg/tasks/prometheusoperator.go: Remove code introduced in https://github.com/openshift/cluster-monitoring-operator/pull/1806 > >pkg/tasks/{prometheus.go, thanos_ruler_user_workload.go, thanos_querier.go}: Remove cleanup code added in https://github.com/openshift/cluster-monitoring-operator/pull/1731 > >Was done for 4.15 in https://github.com/openshift/cluster-monitoring-operator/pull/2132 > >Make some users who don't want to see the unnecessary 404 on 4.14, happy. > > > >* [ ] I added CHANGELOG entry for this change. >* [ ] No user facing changes, so no entry in CHANGELOG was needed. > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 4 days ago

@machine424: This pull request references MON-3422 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target only the "4.13.z" version, but multiple target versions were set.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2496): >pkg/tasks/prometheusoperator.go: Remove code introduced in https://github.com/openshift/cluster-monitoring-operator/pull/1806 > >pkg/tasks/{prometheus.go, thanos_ruler_user_workload.go, thanos_querier.go}: Remove cleanup code added in https://github.com/openshift/cluster-monitoring-operator/pull/1731 > >Was done for 4.15 in https://github.com/openshift/cluster-monitoring-operator/pull/2132 > >Make some users who don't want to see the unnecessary 404 on 4.14, happy. > > > >* [ ] I added CHANGELOG entry for this change. >* [ ] No user facing changes, so no entry in CHANGELOG was needed. > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 4 days ago

@machine424: This pull request references MON-3422 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target only the "4.14.z" version, but multiple target versions were set.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2496): >pkg/tasks/prometheusoperator.go: Remove code introduced in https://github.com/openshift/cluster-monitoring-operator/pull/1806 > >pkg/tasks/{prometheus.go, thanos_ruler_user_workload.go, thanos_querier.go}: Remove cleanup code added in https://github.com/openshift/cluster-monitoring-operator/pull/1731 > >Was done for 4.15 in https://github.com/openshift/cluster-monitoring-operator/pull/2132 > >Make some users who don't want to see the unnecessary 404 on 4.14, happy. > > > >* [ ] I added CHANGELOG entry for this change. >* [ ] No user facing changes, so no entry in CHANGELOG was needed. > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
machine424 commented 4 days ago

/retest-required

jan--f commented 4 days ago

/lgtm /label backport-risk-assessed

jan--f commented 4 days ago

/retest

openshift-ci[bot] commented 4 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jan--f, machine424

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-monitoring-operator/blob/release-4.14/OWNERS)~~ [jan--f] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
machine424 commented 4 days ago

/retitle MON-4054: Remove temporary no more needed code

openshift-ci-robot commented 4 days ago

@machine424: This pull request references MON-4054 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target only the "4.14.z" version, but multiple target versions were set.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2496): >pkg/tasks/prometheusoperator.go: Remove code introduced in https://github.com/openshift/cluster-monitoring-operator/pull/1806 > >pkg/tasks/{prometheus.go, thanos_ruler_user_workload.go, thanos_querier.go}: Remove cleanup code added in https://github.com/openshift/cluster-monitoring-operator/pull/1731 > >Was done for 4.15 in https://github.com/openshift/cluster-monitoring-operator/pull/2132 > >Make some users who don't want to see the unnecessary 404 on 4.14, happy. > > > >* [ ] I added CHANGELOG entry for this change. >* [ ] No user facing changes, so no entry in CHANGELOG was needed. > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
machine424 commented 4 days ago

/jira refresh

openshift-ci-robot commented 4 days ago

@machine424: This pull request references MON-4054 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target only the "4.14.z" version, but multiple target versions were set.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2496#issuecomment-2416603539): >/jira refresh > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 4 days ago

@machine424: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/rules 4bf6d86aa40238de438c1610beffa33ea4a240cb link true /test rules
ci/prow/go-fmt 4bf6d86aa40238de438c1610beffa33ea4a240cb link true /test go-fmt
ci/prow/e2e-aws-ovn-single-node 4bf6d86aa40238de438c1610beffa33ea4a240cb link false /test e2e-aws-ovn-single-node
ci/prow/vendor 4bf6d86aa40238de438c1610beffa33ea4a240cb link true /test vendor
ci/prow/e2e-agnostic-operator 4bf6d86aa40238de438c1610beffa33ea4a240cb link true /test e2e-agnostic-operator
ci/prow/verify 4bf6d86aa40238de438c1610beffa33ea4a240cb link true /test verify
ci/prow/generate 4bf6d86aa40238de438c1610beffa33ea4a240cb link true /test generate
ci/prow/e2e-aws-ovn-upgrade 4bf6d86aa40238de438c1610beffa33ea4a240cb link true /test e2e-aws-ovn-upgrade
ci/prow/unit 4bf6d86aa40238de438c1610beffa33ea4a240cb link true /test unit
ci/prow/shellcheck 4bf6d86aa40238de438c1610beffa33ea4a240cb link true /test shellcheck
ci/prow/e2e-aws-ovn 4bf6d86aa40238de438c1610beffa33ea4a240cb link true /test e2e-aws-ovn
ci/prow/images 4bf6d86aa40238de438c1610beffa33ea4a240cb link true /test images
ci/prow/jsonnet-fmt 4bf6d86aa40238de438c1610beffa33ea4a240cb link true /test jsonnet-fmt

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
machine424 commented 4 days ago

/jira refresh

openshift-ci-robot commented 4 days ago

@machine424: This pull request references MON-4054 which is a valid jira issue.

In response to [this](https://github.com/openshift/cluster-monitoring-operator/pull/2496#issuecomment-2416976910): >/jira refresh > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-monitoring-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
machine424 commented 2 days ago

cc @juzhao if you could take a look.