search

openshift / cluster-nfd-operator

The Cluster Node Feature Discovery operator manages detection of hardware features and configuration in a Openshift cluster.
Apache License 2.0
34 stars 42 forks source link

Replace all non-klog logging lines with klog #203

Closed courtneypacheco closed 3 years ago

courtneypacheco commented 3 years ago

The operator code is inconsistent in terms of the types of logging methods used. Prior to this commit, logr, logf, etc. were being used in addition to klog. To keep things consistent, I have removed all non-klog logging statements and replaced them with klog logging statements.

courtneypacheco commented 3 years ago

/retest-required

courtneypacheco commented 3 years ago

/assign @ArangoGutierrez

courtneypacheco commented 3 years ago

/retest-required

courtneypacheco commented 3 years ago

/retest-required

courtneypacheco commented 3 years ago

/retest-required

courtneypacheco commented 3 years ago

/retest-required

courtneypacheco commented 3 years ago

/retest-required

ArangoGutierrez commented 3 years ago

after this PR, TODO should be klog/v2

courtneypacheco commented 3 years ago

@ArangoGutierrez I changed the klog version to v2.9.0 as requested. PTAL.

ArangoGutierrez commented 3 years ago

Testing this one today

ArangoGutierrez commented 3 years ago

Rebase after https://github.com/openshift/cluster-nfd-operator/pull/184 merge

openshift-ci[bot] commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, courtneypacheco

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-nfd-operator/blob/master/OWNERS)~~ [ArangoGutierrez] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment