Prepare repo for 4.9 freeze

openshift / cluster-nfd-operator

The Cluster Node Feature Discovery operator manages detection of hardware features and configuration in a Openshift cluster.

Apache License 2.0

34 stars 42 forks source link

Prepare repo for 4.9 freeze #208

Closed ArangoGutierrez closed 3 years ago

ArangoGutierrez commented 3 years ago

Cheery-pick changes from upstream, and accommodate Operator for last NFD changes

Code optimization (remove not needed it/else checks)
Delete validateUpdateEvent func, not used currently, left as TODO once we have more SRE experience on running NFD
Add support for config IMAGE_TAG and rbac proxy image
Add support for extraLabelNs, resourceLabels, labelWhiteList
Fix rbac kustomize location and uniq project dir
Makefile: make BUNDLE_IMG env var sensible
Delete updateAvailableCondition func, not needed since we straight update the CR using controller-runtime

ArangoGutierrez commented 3 years ago

/cc @wabouhamad @lenahorsley @courtneypacheco @dagrayvid

ArangoGutierrez commented 3 years ago

/uncc zvonkok

ArangoGutierrez commented 3 years ago

/assign @wabouhamad @courtneypacheco

ArangoGutierrez commented 3 years ago

/retest required

openshift-ci[bot] commented 3 years ago

@ArangoGutierrez: The /retest command does not accept any targets. The following commands are available to trigger required jobs:

/test ci-index
/test e2e-aws
/test images
/test unit
/test verify

Use /test all to run all jobs.

In response to [this](https://github.com/openshift/cluster-nfd-operator/pull/208#issuecomment-912568085): >/retest required Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

ArangoGutierrez commented 3 years ago

/test all

ArangoGutierrez commented 3 years ago

/test all

dagrayvid commented 3 years ago

Thanks for addressing all of my comments @ArangoGutierrez

/lgtm

openshift-ci[bot] commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, dagrayvid, lenahorsley

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-nfd-operator/blob/master/OWNERS)~~ [ArangoGutierrez] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

lenahorsley commented 3 years ago

/lgtm

Tested 3 September 2021 Created and deployed a bundle to an AWS cluster. All worker nodes were labeled correctly.