search

openshift / cluster-nfd-operator

The Cluster Node Feature Discovery operator manages detection of hardware features and configuration in a Openshift cluster.
Apache License 2.0
34 stars 42 forks source link

Bug 2022518: NFD operator failing greenwave CVP tests #225

Closed ArangoGutierrez closed 2 years ago

ArangoGutierrez commented 2 years ago

OLM manages the lifecycle of the serviceaccount which is specified in the CSV. If it's added again as a separate manifest it may interfere and cause issues with OLM’s management process (like causing upgrade failures etc). That's the reason it need not be added by the user separately. The suggested action is to remove the service account config yaml file from the operator’s manifest folder.

Signed-off-by: Carlos Eduardo Arango Gutierrez carangog@redhat.com

openshift-ci[bot] commented 2 years ago

@ArangoGutierrez: This pull request references Bugzilla bug 2022518, which is invalid:

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/cluster-nfd-operator/pull/225): >Bug 2022518: NFD operator failing greenwave CVP tests Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
ArangoGutierrez commented 2 years ago

/bugzilla refresh

ArangoGutierrez commented 2 years ago

/bugzilla refresh

openshift-ci[bot] commented 2 years ago

@ArangoGutierrez: This pull request references Bugzilla bug 2022518, which is invalid:

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/cluster-nfd-operator/pull/225#issuecomment-966617669): >/bugzilla refresh Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 2 years ago

@ArangoGutierrez: This pull request references Bugzilla bug 2022518, which is invalid:

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/cluster-nfd-operator/pull/225#issuecomment-966616660): >/bugzilla refresh Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-nfd-operator/blob/release-4.9/OWNERS)~~ [ArangoGutierrez] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
dagrayvid commented 2 years ago

Makes sense to me. The BZ needs some care.

/lgtm

ArangoGutierrez commented 2 years ago

/cc @wabouhamad @lenahorsley

openshift-bot commented 2 years ago

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci[bot] commented 2 years ago

@openshift-bot: This pull request references Bugzilla bug 2022518, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target release (4.9.z) matches configured target release for branch (4.9.z) * bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST) * dependent bug [Bugzilla bug 2022496](https://bugzilla.redhat.com/show_bug.cgi?id=2022496) is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE)) * dependent [Bugzilla bug 2022496](https://bugzilla.redhat.com/show_bug.cgi?id=2022496) targets the "4.10.0" release, which is one of the valid target releases: 4.10.0 * bug has dependents

Requesting review from QA contact: /cc @wabouhamad

In response to [this](https://github.com/openshift/cluster-nfd-operator/pull/225#issuecomment-967749949): >/bugzilla refresh > >Recalculating validity in case the underlying Bugzilla bug has changed. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 2 years ago

@ArangoGutierrez: All pull requests linked via external trackers have merged:

Bugzilla bug 2022518 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/cluster-nfd-operator/pull/225): >Bug 2022518: NFD operator failing greenwave CVP tests Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.