search

openshift / cluster-nfd-operator

The Cluster Node Feature Discovery operator manages detection of hardware features and configuration in a Openshift cluster.
Apache License 2.0
34 stars 42 forks source link

[release-4.9] Bug 2055318: Do not set explicitly image pull policy to Always #243

Closed cynepco3hahue closed 2 years ago

cynepco3hahue commented 2 years ago

In Telco far edge use case, a cluster might have limited management bandwidth. Upgrading such a cluster is expected to be time-limited (capped by a maintenance window) and will involve container image pre-caching on the node.

Image pre-caching solution for nodes with limited management bandwidth relies on the assumption, that workloads can use locally stored images without contacting a registry. This is possible if the container image pull policy is set to "IfNotPresent". The NFD operator is using Always as the pull policy, we should delete the policy and have the default behavior.

From https://kubernetes.io/docs/concepts/containers/images/#imagepullpolicy-defaulting

When you (or a controller) submit a new Pod to the API server, your cluster sets the image pull policy field when specific conditions are met:

if you omit the imagePullPolicy field, and the tag for the container image is :latest, imagePullPolicy is automatically set to Always

if you omit the imagePullPolicy field, and you don't specify the tag for the container image, imagePullPolicy is automatically set to Always;

if you omit the imagePullPolicy field, and you specify the tag for the container image that isn't :latest, the imagePullPolicy is automatically set to IfNotPresent.

Signed-off-by: Artyom Lukianov alukiano@redhat.com

openshift-ci[bot] commented 2 years ago

@cynepco3hahue: This pull request references Bugzilla bug 2055318, which is invalid:

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/cluster-nfd-operator/pull/243): >[release-4.9] Bug 2055318: Do not set explicitly image pull policy to Always Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
cynepco3hahue commented 2 years ago

hm it fails on operator installation with the error

  - message: 'constraints not satisfiable: no operators found in package nfd in the
      catalog referenced by subscription oo-mcbpf, subscription oo-mcbpf exists'

I will try to retest, but I am feeling it is some real problem.

cynepco3hahue commented 2 years ago

/retest

ArangoGutierrez commented 2 years ago

/bugzilla refresh

openshift-ci[bot] commented 2 years ago

@ArangoGutierrez: This pull request references Bugzilla bug 2055318, which is invalid:

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/cluster-nfd-operator/pull/243#issuecomment-1042065084): >/bugzilla refresh Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
ArangoGutierrez commented 2 years ago

/retest-required

openshift-bot commented 2 years ago

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented 2 years ago

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented 2 years ago

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented 2 years ago

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented 2 years ago

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci[bot] commented 2 years ago

@openshift-bot: This pull request references Bugzilla bug 2055318, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target release (4.9.z) matches configured target release for branch (4.9.z) * bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST) * dependent bug [Bugzilla bug 2055244](https://bugzilla.redhat.com/show_bug.cgi?id=2055244) is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE)) * dependent [Bugzilla bug 2055244](https://bugzilla.redhat.com/show_bug.cgi?id=2055244) targets the "4.10.0" release, which is one of the valid target releases: 4.10.0 * bug has dependents

Requesting review from QA contact: /cc @wabouhamad

In response to [this](https://github.com/openshift/cluster-nfd-operator/pull/243#issuecomment-1042462909): >/bugzilla refresh > >Recalculating validity in case the underlying Bugzilla bug has changed. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-bot commented 2 years ago

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented 2 years ago

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented 2 years ago

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented 2 years ago

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented 2 years ago

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented 2 years ago

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented 2 years ago

/retest-required

Please review the full test history for this PR and help us cut down flakes.

cynepco3hahue commented 2 years ago

I think I found the issue - https://github.com/openshift/cluster-nfd-operator/pull/243/commits/e0f91cca1127bd5a385eb20726c1417b1f3394b7

openshift-ci[bot] commented 2 years ago

@cynepco3hahue: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, cynepco3hahue

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-nfd-operator/blob/release-4.9/OWNERS)~~ [ArangoGutierrez] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 2 years ago

@cynepco3hahue: All pull requests linked via external trackers have merged:

Bugzilla bug 2055318 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/cluster-nfd-operator/pull/243): >[release-4.9] Bug 2055318: Do not set explicitly image pull policy to Always Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.