search

openshift / cluster-nfd-operator

The Cluster Node Feature Discovery operator manages detection of hardware features and configuration in a Openshift cluster.
Apache License 2.0
34 stars 42 forks source link

Bug 2058256: use library-go for leader elect options #246

Closed ArangoGutierrez closed 2 years ago

openshift-ci[bot] commented 2 years ago

@ArangoGutierrez: This pull request references Bugzilla bug 2058256, which is invalid:

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/cluster-nfd-operator/pull/246): >Bug 2058256: use library-go for leader elect options Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
ArangoGutierrez commented 2 years ago

/assign @sreber84

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-nfd-operator/blob/master/OWNERS)~~ [ArangoGutierrez] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ArangoGutierrez commented 2 years ago

/uncc jmencak kpouget /cc @wabouhamad @lenahorsley

ArangoGutierrez commented 2 years ago

I will coordinate with Simon before moving forward with this PR /hold

ArangoGutierrez commented 2 years ago

@ArangoGutierrez: This pull request references Bugzilla bug 2058256, which is invalid:

  • expected the bug to target the "4.11.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

@sreber84 if we want a fix into 4.8, we will need to edit the bz to point to 4.11 and then make our way down to 4.8

ArangoGutierrez commented 2 years ago

Hey @sreber84 any updates testing this?

ArangoGutierrez commented 2 years ago

@wabouhamad @lenahorsley Have you tested this?

ArangoGutierrez commented 2 years ago

/hold cancel

ArangoGutierrez commented 2 years ago

/bugzilla refresh

openshift-ci[bot] commented 2 years ago

@ArangoGutierrez: An error was encountered removing this pull request from the external tracker bugs for bug 2058256 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message. JSONRPC error 32000: You have attempted to access the API either using an unsupported method or using one or more unsupported parameters. You must use the 'Authorization' header to authenticate to the API and you must remove all unsupported parameters from the query. The unsupported parameters are: Bugzilla_login, Bugzilla_password, Bugzilla_token, Bugzilla_api_key. See https://bugzilla.redhat.com/docs/en/html/api/core/v1/general.html#authentication for details on using the 'Authorization' header.

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to [this](https://github.com/openshift/cluster-nfd-operator/pull/246): >Bug 2058256: use library-go for leader elect options Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 2 years ago

@ArangoGutierrez: An error was encountered adding this pull request to the external tracker bugs for bug 2058256 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message. JSONRPC error 32000: You have attempted to access the API either using an unsupported method or using one or more unsupported parameters. You must use the 'Authorization' header to authenticate to the API and you must remove all unsupported parameters from the query. The unsupported parameters are: Bugzilla_login, Bugzilla_password, Bugzilla_token, Bugzilla_api_key. See https://bugzilla.redhat.com/docs/en/html/api/core/v1/general.html#authentication for details on using the 'Authorization' header.

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to [this](https://github.com/openshift/cluster-nfd-operator/pull/246#issuecomment-1067201487): >/bugzilla refresh Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 2 years ago

@ArangoGutierrez: An error was encountered adding this pull request to the external tracker bugs for bug 2058256 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message. JSONRPC error 32000: You have attempted to access the API either using an unsupported method or using one or more unsupported parameters. You must use the 'Authorization' header to authenticate to the API and you must remove all unsupported parameters from the query. The unsupported parameters are: Bugzilla_login, Bugzilla_password, Bugzilla_token, Bugzilla_api_key. See https://bugzilla.redhat.com/docs/en/html/api/core/v1/general.html#authentication for details on using the 'Authorization' header.

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to [this](https://github.com/openshift/cluster-nfd-operator/pull/246): >Bug 2058256: use library-go for leader elect options Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
ArangoGutierrez commented 2 years ago

/bugzilla refresh

openshift-ci[bot] commented 2 years ago

@ArangoGutierrez: An error was encountered adding this pull request to the external tracker bugs for bug 2058256 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message. JSONRPC error 32000: You have attempted to access the API either using an unsupported method or using one or more unsupported parameters. You must use the 'Authorization' header to authenticate to the API and you must remove all unsupported parameters from the query. The unsupported parameters are: Bugzilla_login, Bugzilla_password, Bugzilla_token, Bugzilla_api_key. See https://bugzilla.redhat.com/docs/en/html/api/core/v1/general.html#authentication for details on using the 'Authorization' header.

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to [this](https://github.com/openshift/cluster-nfd-operator/pull/246#issuecomment-1067201655): >/bugzilla refresh Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
ArangoGutierrez commented 2 years ago

/bugzilla refresh

openshift-ci[bot] commented 2 years ago

@ArangoGutierrez: An error was encountered adding this pull request to the external tracker bugs for bug 2058256 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message. JSONRPC error 32000: You have attempted to access the API either using an unsupported method or using one or more unsupported parameters. You must use the 'Authorization' header to authenticate to the API and you must remove all unsupported parameters from the query. The unsupported parameters are: Bugzilla_login, Bugzilla_password, Bugzilla_token, Bugzilla_api_key. See https://bugzilla.redhat.com/docs/en/html/api/core/v1/general.html#authentication for details on using the 'Authorization' header.

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to [this](https://github.com/openshift/cluster-nfd-operator/pull/246#issuecomment-1067201974): >/bugzilla refresh Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
ArangoGutierrez commented 2 years ago

/bugzilla refresh

openshift-ci[bot] commented 2 years ago

@ArangoGutierrez: An error was encountered adding this pull request to the external tracker bugs for bug 2058256 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message. JSONRPC error 32000: You have attempted to access the API either using an unsupported method or using one or more unsupported parameters. You must use the 'Authorization' header to authenticate to the API and you must remove all unsupported parameters from the query. The unsupported parameters are: Bugzilla_login, Bugzilla_password, Bugzilla_token, Bugzilla_api_key. See https://bugzilla.redhat.com/docs/en/html/api/core/v1/general.html#authentication for details on using the 'Authorization' header.

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to [this](https://github.com/openshift/cluster-nfd-operator/pull/246#issuecomment-1067202876): >/bugzilla refresh Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
ArangoGutierrez commented 2 years ago

/test all

openshift-ci[bot] commented 2 years ago

@ArangoGutierrez: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
lenahorsley commented 2 years ago

Tested 15 March 2022 Verified on the4.11.0-0.nightly-2022-03-15-060211 build on an AWS cluster (3 worker and 3 master nodes).

NFD version (from a bundle): quay.io/lenahorsley/nfd-operator-bundle:4.11.202203151049 Kube version: v1.23.3+f017760

Tested performed:

  1. Build and deploy NFD bundle. Check the worker node labels.
  2. Add a worker node and check new node labels.
  3. Remove the newly added node and check the labels on the remaining nodes.
  4. Log creation and stability.
  5. Check for pods restarts in the openshift-etcd namespace (there were no restarts).

All tests were executed successfully.

openshift-bot commented 2 years ago

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci[bot] commented 2 years ago

@openshift-bot: This pull request references Bugzilla bug 2058256, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target release (4.11.0) matches configured target release for branch (4.11.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact: /cc @wabouhamad

In response to [this](https://github.com/openshift/cluster-nfd-operator/pull/246#issuecomment-1068619683): >/bugzilla refresh > >Recalculating validity in case the underlying Bugzilla bug has changed. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 2 years ago

@ArangoGutierrez: All pull requests linked via external trackers have merged:

Bugzilla bug 2058256 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/cluster-nfd-operator/pull/246): >Bug 2058256: use library-go for leader elect options Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.