search

openshift / cluster-nfd-operator

The Cluster Node Feature Discovery operator manages detection of hardware features and configuration in a Openshift cluster.
Apache License 2.0
34 stars 42 forks source link

Add skipper configuration #272

Closed yevgeny-shnaidman closed 2 years ago

yevgeny-shnaidman commented 2 years ago

Allows to execute most of the command in the Makefile via skipper

MGMT-11417

yevgeny-shnaidman commented 2 years ago

/cc @ArangoGutierrez

ArangoGutierrez commented 2 years ago

More info on Skipper : https://pkg.go.dev/github.com/zalando/skipper

ArangoGutierrez commented 2 years ago

Is this PR mostly for devel purposes? Bc remeber the official Dockerfile is built by ART, so you will end up maintaining 2 dockerfiles, devel and prod. Is this ok?

yevgeny-shnaidman commented 2 years ago

skipper is a tool that allows developer to build/configure/etc' the repo without installing anything on their laptop. and quickly switch between different project on the same machine. It does not interfere with the ART flow, since it is a different dockerfile. Maintaining is not an issue, since all we have to keep track of is a GO version

yevgeny-shnaidman commented 2 years ago

Is this PR mostly for devel purposes? Bc remeber the official Dockerfile is built by ART, so you will end up maintaining 2 dockerfiles, devel and prod. Is this ok?

skipper is a tool that allows developer to build/configure/etc' the repo without installing anything on their laptop. and quickly switch between different project on the same machine. It does not interfere with the ART flow, since it is a different dockerfile. Maintaining is not an issue, since all we have to keep track of is a GO version

ArangoGutierrez commented 2 years ago

Is this PR mostly for devel purposes? Bc remeber the official Dockerfile is built by ART, so you will end up maintaining 2 dockerfiles, devel and prod. Is this ok?

skipper is a tool that allows developer to build/configure/etc' the repo without installing anything on their laptop. and quickly switch between different project on the same machine. It does not interfere with the ART flow, since it is a different dockerfile. Maintaining is not an issue, since all we have to keep track of is a GO version

be aware that ART tracks the file called Dockerfile, and nothing else to build the final prod image. /lgtm /approve

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, yevgeny-shnaidman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-nfd-operator/blob/master/OWNERS)~~ [ArangoGutierrez] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 2 years ago

@yevgeny-shnaidman: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).