search

openshift / cluster-nfd-operator

The Cluster Node Feature Discovery operator manages detection of hardware features and configuration in a Openshift cluster.
Apache License 2.0
34 stars 42 forks source link

Allow multiple NFD CR in the cluster #276

Closed yevgeny-shnaidman closed 1 year ago

yevgeny-shnaidman commented 1 year ago

This PR allows supporting different NFD CRs in the running cluster. Currently NFD supports only one NFD CRs per namespace, and it only watches the namespace it was deployed into. This PR supplies the final brick to allow deploying additional NFD CRs, each one in its own namespace. 1) NFD operator should watch cluster-wide namespaces 2) on each new CR a master/worker will be deployed in the correlated namespace, with the appropriate Role/RoleBinding 3) NFD will rely on the ClusterRole/ClusterRoleBinding/SCC deployed by the first CR

This implementation will probably be changed in the future, once we consolidate multiple CRs issues in the upstream.

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yevgeny-shnaidman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-nfd-operator/blob/master/OWNERS)~~ [yevgeny-shnaidman] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
yevgeny-shnaidman commented 1 year ago

/assign @chr15p

openshift-ci[bot] commented 1 year ago

@yevgeny-shnaidman: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
chr15p commented 1 year ago

/lgtm

yevgeny-shnaidman commented 1 year ago

/cherry-pick release-4.12

openshift-cherrypick-robot commented 1 year ago

@yevgeny-shnaidman: new pull request created: #284

In response to [this](https://github.com/openshift/cluster-nfd-operator/pull/276#issuecomment-1315383745): >/cherry-pick release-4.12 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.